-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support volatile messages #821
Conversation
009aec5
to
4b0db1d
Compare
We can do this without a function? If we make |
Like expect.js does? I will work on it. |
👍 |
Conflicts: lib/socket.js
Done. I used |
Another way is to create a class only for flags which has minimum sets of methods and properties instead like: function Flag(socket, flag) {
this.flags = {};
this.flags[flag] = true;
this.socket = socket;
// TODO: creates flag properties.
}
Flag.prototype.emit = function() {
this.socket.flags = this.flags;
this.socket.emit.apply(this.socket, arguments);
return this.socket;
};
Flag.prototype.compress = function() {...}
// socket.js
function Socket() {
...
this.volatile = new Flag(this, 'volatile');
} |
any plan to finish this feature? |
Any plans for this? It would be much appreciated. Thanks! |
What is the state of this? I'd love to have this feature. As it stands, when my clients reconnect to the server, all of their pending requests come in at once and this causes some problems. |
Bumping for updates on this feature. |
Yet another bump. :) |
Another request for client>server volatile messaging |
Merged into 7ddad2c and included in v3. |
This PR adds
socket#volatile()
.We have to merge socketio/engine.io-client#375 to pass all tests.
Related: #283, #710, socketio/socket.io#2003