Add volatile messages #1292
Closed
Add volatile messages #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrachequesne I just submitted my first PR to add volatile messages but it's failed for Travis-CI checking although my code was run well on my local. Can you help to have a look and give me some suggestions to fix this? So sorry because this's my first PR on a big project like this. Thanks. |
added 2 commits
April 21, 2019 18:17
…ket.io-client * 'master' of https://github.com/thoqbk/socket.io-client: Add volatile messages * 'master' of https://github.com/thoqbk/socket.io-client: Add volatile messages
|
Bump ⏳ |
|
Merged into 7ddad2c and included in v3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
If the server went down, the client keeps backing failed messages, so when the server comes back online, it will be overloaded by unneeded messages.
New behaviour
Add
socket.volatile()to specify emitted data can be dropped if the connection is not ready to send.Other information (e.g. related issues)
Related issues: