-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/volatile support #710
Add/volatile support #710
Conversation
also, I was only able to run zuul tests locally because my internet connection is really wonky right now |
addresses a very old issue here #283 |
The underlying socket should be still writable, but if busy writing out packets we need to ditch the packet. |
This is why I added a callback to the engine.io writes btw. The idea was to match the This means that we can still swap the underlying transport and support packet volatility. |
@guille are you saying ditch the check for |
@guille let me know how you feel now 🍪. also, the |
I'm a little concerned about the testing strategy relying on the knowledge of a private member ( |
this seems like a solid feature to me. Let me know what y'all think!