Support placeholder in SofaService and SofaReference annotation. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个竟然是用代理去实现的，又学到了新姿势！一直以为注解类是final不能代理，直到看到了基于annotation类内聚做代理的，艺术艺术。 |
| SofaService sofaServiceAnnotation = beanClass.getAnnotation(SofaService.class); | ||
| AnnotationWrapperBuilder<SofaService> builder = AnnotationWrapperBuilder.wrap( | ||
| beanClass.getAnnotation(SofaService.class)).withBinder(binder); | ||
| SofaService sofaServiceAnnotation = builder.build(); | ||
|
|
||
| if (sofaServiceAnnotation == null) { | ||
| return; |
There was a problem hiding this comment.
I this we should first check whether sofaServiceAnnotation is null ,then wrap it , otherwise there will be many temp AnnotationWrapperBuilder objects since ServiceAnnotationBeanPostProcessor is a BeanPostProcessor which will work on many beans and only a very small part of them are annotated with @SofaService. At the same time, we can assert delegate not null on AnnotationWrapperBuilder.
| AnnotationWrapperBuilder<SofaReference> builder = AnnotationWrapperBuilder.wrap( | ||
| field.getAnnotation(SofaReference.class)).withBinder(binder); | ||
| SofaReference sofaReferenceAnnotation = builder.build(); | ||
|
|
| * @since 2.5.2 | ||
| */ | ||
| public interface PlaceHolderBinder { | ||
| String bind(String string); |
There was a problem hiding this comment.
Please add comment for this interface and method. And should we provide a default Implement? I see a lot of duplicate implements below.
straybirdzls
approved these changes
Nov 14, 2018
QilongZhang
added a commit
to QilongZhang/sofa-boot
that referenced
this pull request
Nov 22, 2018
…astack#264) * support placeholder in SofaService and SofaReference annotation
straybirdzls
pushed a commit
that referenced
this pull request
Nov 23, 2018
… (#282) * support placeholder in SofaService and SofaReference annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#260