Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placeholder in SofaService and SofaReference annotation. (#264) #282

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

QilongZhang
Copy link
Contributor

  • support placeholder in SofaService and SofaReference annotation

…astack#264)

* support placeholder in SofaService and SofaReference annotation
@QilongZhang QilongZhang added the enhancement New feature or request label Nov 22, 2018
@QilongZhang QilongZhang added this to the 3.1.0 milestone Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #282 into master will increase coverage by 0.65%.
The diff coverage is 85.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   59.53%   60.19%   +0.65%     
==========================================
  Files          72       73       +1     
  Lines        1735     1781      +46     
  Branches      197      203       +6     
==========================================
+ Hits         1033     1072      +39     
- Misses        556      557       +1     
- Partials      146      152       +6
Impacted Files Coverage Δ
...ime/spring/ServiceAnnotationBeanPostProcessor.java 64.86% <100%> (+3.86%) ⬆️
...tation/PlaceHolderAnnotationInvocationHandler.java 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4e257...9c28b19. Read the comment docs.

@straybirdzls straybirdzls merged commit 0197fd0 into sofastack:master Nov 23, 2018
@QilongZhang QilongZhang deleted the cherry-pick-placehold branch December 26, 2018 14:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants