Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSC for Android #1842

Merged
merged 14 commits into from
Mar 29, 2021
Merged

JSC for Android #1842

merged 14 commits into from
Mar 29, 2021

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Mar 17, 2021

Description

Added support for JSC runtime on Android

Checklist

  • Ensured that CI passes

@piaskowyk piaskowyk marked this pull request as ready for review March 24, 2021 11:22
Copy link
Contributor

@Szymon20000 Szymon20000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@piaskowyk piaskowyk merged commit 60bb8da into master Mar 29, 2021
@piaskowyk piaskowyk deleted the @piaskowyk/android-jsc branch March 29, 2021 16:33
@Yonom
Copy link

Yonom commented Mar 31, 2021

@piaskowyk do you have an ETA on when this will land?

@piaskowyk
Copy link
Member Author

@Yonom We released it in the latest version 2.1.0.

@zachgibson
Copy link

Does this PR remove the need to use Hermes on Android?

@piaskowyk
Copy link
Member Author

@zachgibson Yes, you can choose JSC or Hermes runtime for Android

@SaeedZhiany
Copy link

@piaskowyk

What about iOS, can also we use this library without Hermes enabled for iOS? if yes what is the minimum version that can be used?

@Arkan4ik
Copy link

Arkan4ik commented Jan 12, 2022

@SaeedZhiany I am using "react-native-reanimated": "^2.3.1", and "react-native": "0.64.2", without hermes enabled and all work fine

@HSReact
Copy link

HSReact commented Jun 15, 2022

@SaeedZhiany I am using "react-native-reanimated": "^2.3.1", and "react-native": "0.64.2", without hermes enabled and all work fine

Hi @Arkan4ik how is the performance of reanimated 2 without hermes? is it better than reanimated 1? Thanks for any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants