Fix runtime creation

[piaskowyk]

Description

In #1842 we use runtime factory from React Native. This factory can decorate runtime by chrome debugger - code here.

facebook::hermes::inspector::chrome::enableDebugging(std::move(adapter), "Hermes React Native");

This line registers runtime in the Metro server with the name Hermes React Native. When we use the same runtime factory to create reanimated runtime, we override React Native runtime in the Metro server because both runtimes have the same name. This happens just with Hermes runtime, so I changed the place where we create runtime and I moved the creation of Hermes runtime to C++ part. Now Metro server can see both runtimes.

Output form Metro server http://localhost:8081/json

json data

[
  {
    "id": "0-2",
    "description": "com.swmansion.reanimated.example",
    "title": "Reanimated Runtime",
    "faviconUrl": "https://reactjs.org/favicon.ico",
    "devtoolsFrontendUrl": "chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=%5B%3A%3A%5D%3A8081%2Finspector%2Fdebug%3Fdevice%3D0%26page%3D2",
    "type": "node",
    "webSocketDebuggerUrl": "ws://[::]:8081/inspector/debug?device=0&page=2",
    "vm": "Hermes"
  },
  {
    "id": "0-1",
    "description": "com.swmansion.reanimated.example",
    "title": "Hermes React Native",
    "faviconUrl": "https://reactjs.org/favicon.ico",
    "devtoolsFrontendUrl": "chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=%5B%3A%3A%5D%3A8081%2Finspector%2Fdebug%3Fdevice%3D0%26page%3D1",
    "type": "node",
    "webSocketDebuggerUrl": "ws://[::]:8081/inspector/debug?device=0&page=1",
    "vm": "Hermes"
  },
  {
    "id": "0--1",
    "description": "don't use",
    "title": "React Native Experimental (Improved Chrome Reloads)",
    "faviconUrl": "https://reactjs.org/favicon.ico",
    "devtoolsFrontendUrl": "chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=%5B%3A%3A%5D%3A8081%2Finspector%2Fdebug%3Fdevice%3D0%26page%3D-1",
    "type": "node",
    "webSocketDebuggerUrl": "ws://[::]:8081/inspector/debug?device=0&page=-1",
    "vm": "don't use"
  }
]

I decided to use getDefaultJSExecutorFactory() method from React Native, to avoid the compilation of Reanimated AAR's files for every JS engine. This a little tricky because I need access to the private method unfortunately but thanks to this we still need just 3 AARs. In additionally this PR should automatically add support for V8 runtime because the library with the V8 engine for React Native replacing the body of getDefaultJSExecutorFactory() method to method returning just V8 runtime - code here.
This PR is also the first big step to make Reanimated debuggable by Flipper or chrome debugger.

Fixes #1955
Fixes #1923

Update about V8:
I can start app with V8 runtime and use V8 as Reanimated runtime, but I found the issue in callWithThis() - this not set jsThis properly here, in effect ProxySetter and SharedValue don't work. This looks like bug in V8 implementation.

Checklist

• Ensured that CI passes

[rplankenhorn]

@piaskowyk I tried pulling this PR down locally and running it but it didn't seem to fix the issue on Android. I still am getting a crash when connecting the Hermes Debugger in Flipper.

[Kudo]

just curious that if adding libhermes here, will mark libhermes.so as NEEDED in libreanimated.so again?
For JSC apps to load libreanimated.so, there should be errors as libhermes.so is not packed into apk.

btw thank you @piaskowyk for the awesome work trying to decouple hermes in reanimated 👍

[Szymon20000]

I think it won't work because RN doesn't provide libhermes.so if you choose to use jsc.

[Szymon20000]

I believe Hermes inspector is available only in debug build so we cannot merge this in the current shape.

[piaskowyk]

I want to back to this in the future.

[Kudo]

@piaskowyk i fixed the v8 callWithThis issue you reported. can you help to revisit the possibility of adding v8 support again when you get a chance?

here are some of my proposals:

1. add v8 support as my fork and also ship v8 aar inside reanimated package.
2. if reanimated can support user to build from source, for people want to use v8 + reanimated, they should build reanimated from source.
3. i think your JSC for Android #1842 approach is still good for jsc and v8. maybe you can use makeHermesRuntime for hermes engine only and runtime factory approach as a generic solution for both jsc and v8.
4. propose a RuntimeFactory from react-native core, so that we don't need differentiate hermes, jsc, and v8.

[mrousavy]

Point 4. sounds very interesting. I've also thought about simply exposing their code to create a runtime instead, which can potentially be overwritten by other runtimes (v8, or more).

[jzxchiang1]

Just wanted to add that @Kudo has been extremely helpful, and I've tried his callWithThis fix and it finally makes reanimated v2 work for Android v8.

This would be huge for all of us v8 users. At a minimum, bundling the v8 AAR inside reanimated would be a great first step.

[DaniyarJakupov]

@piaskowyk sorry to bother you, but are there any updates on v8 support?