Fix new implementation iOS crash on reload while animation is running #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
NativeReanimatedModule destructor
tomekzaw
changed the title
NativeReanimatedModule destructor
kmagiera
approved these changes
Dec 5, 2022
kmagiera
approved these changes
Dec 8, 2022
piaskowyk
approved these changes
Dec 8, 2022
kmagiera
pushed a commit
that referenced
this pull request
Dec 13, 2022
…#3837) ## Summary This PR fixes an iOS crash with Hermes on app reload that occurs only if some animation is still running: <img width="1512" alt="crash" src="https://user-images.githubusercontent.com/20516055/205723759-1ed56999-64e7-4ce6-a4ae-baa686f2b2a4.png"> ## Test plan 1. Build and launch Example app on iOS simulator 2. Open Animated Style Update Example 3. Increase duration to 5000 ms 4. Click "Toggle" button 5. Press <kbd>r</kbd> in simulator 6. Make sure the app reloads correctly
|
Which version is this going to be published in? @tomekzaw |
|
Hey, this change will be published in 3.0.0-rc.9 (probably next week). |
|
@tomekzaw Just tried rc-9 and this issue is not fixed. Still getting this while the animation is running. Furthermore, getting another bug of |
|
Opened issue #3895 with reproduction |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…software-mansion#3837) ## Summary This PR fixes an iOS crash with Hermes on app reload that occurs only if some animation is still running: <img width="1512" alt="crash" src="https://user-images.githubusercontent.com/20516055/205723759-1ed56999-64e7-4ce6-a4ae-baa686f2b2a4.png"> ## Test plan 1. Build and launch Example app on iOS simulator 2. Open Animated Style Update Example 3. Increase duration to 5000 ms 4. Click "Toggle" button 5. Press <kbd>r</kbd> in simulator 6. Make sure the app reloads correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an iOS crash with Hermes on app reload that occurs only if some animation is still running:
Test plan