Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new implementation iOS crash on reload while animation is running #3837

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix new implementation iOS crash on reload while animation is running #3837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Common/cpp/NativeModules/NativeReanimatedModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@ void NativeReanimatedModule::installCoreFunctions(
NativeReanimatedModule::~NativeReanimatedModule() {
if (runtimeHelper) {
runtimeHelper->valueUnpacker = nullptr;
// event handler registry stores some JSI values from UI runtime, so it has
// to go away before we tear down the runtime
// event handler registry and frame callbacks store some JSI values from UI
// runtime, so they have to go away before we tear down the runtime
eventHandlerRegistry.reset();
frameCallbacks.clear();
runtime.reset();
// make sure uiRuntimeDestroyed is set after the runtime is deallocated
runtimeHelper->uiRuntimeDestroyed = true;
Expand Down