Skip to content

Commit

Permalink
chore(Android): remove unnecesary check in Android build code (#2608)
Browse files Browse the repository at this point in the history
## Description

Since 0.72 RN uses AGP 7.4.x (see #2603) and we do not support any older
versions.

## Changes

Removed the check and merged both `buildFeature`s


## Test code and steps to reproduce

Passing Android build

## Checklist

- [x] Ensured that CI passes
  • Loading branch information
kkafar authored Jan 8, 2025
1 parent fbc9a00 commit e6b9aa0
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ android {
compileSdkVersion safeExtGet('compileSdkVersion', rnsDefaultCompileSdkVersion)
namespace "com.swmansion.rnscreens"

def agpVersion = Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
buildFeatures {
buildConfig true
}
}

// Used to override the NDK path/version on internal CI or by allowing
// users to customize the NDK path/version from their root project (e.g. for M1 support)
if (rootProject.hasProperty("ndkPath")) {
Expand Down Expand Up @@ -135,6 +128,7 @@ android {
}
buildFeatures {
prefab true
buildConfig true
}
externalNativeBuild {
cmake {
Expand Down

0 comments on commit e6b9aa0

Please sign in to comment.