Crashing when updating android to api target 35 #2257

corbella83 · 2024-07-19T09:13:46Z

Description

All versions of "react-native-screens" are crashing when targeting android app to api level 35 due to NoSuchMethodError:

java.lang.NoSuchMethodError: No interface method removeLast()Ljava/lang/Object; in class Ljava/util/List; or its super classes (declaration of 'java.util.List' appears in /apex/com.android.art/javalib/core-oj.jar)
at com.swmansion.rnscreens.ScreenStack.obtainDrawingOp(ScreenStack.kt:319)
at com.swmansion.rnscreens.ScreenStack.drawChild(ScreenStack.kt:303)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4538)

Is this line:
if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.**removeLast**()

And means that removeLast is not available anymore. Replacing it to this works well:

if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.removeAt(drawingOpPool.size - 1)

This is a known issue from android: official android documentation

Steps to reproduce

Create a react-native project CLI, using 0.74.3 and add dependency of react-native-screens 3.32.0
Configure compileSdkVersion and targetSdkVersion of the android project to use api level 34
Execute android app and ensure everything is working
Change compileSdkVersion and targetSdkVersion to use api level 35
Execute android app and it will crash

Screens version

3.32.0

React Native version

0.74.3

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

None

Device

Real device

Device model

Samsung Galaxy S22

Acknowledgements

Yes

The text was updated successfully, but these errors were encountered:

github-actions · 2024-07-19T09:14:03Z

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

github-actions · 2024-07-19T09:17:50Z

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

corbella83 · 2024-07-19T09:20:42Z

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

I'm not going to create a new project, configure it, and upload to github for that small change. Every project you have installed will behave the same if you use android api level35.
PR #2256

@corbella83

## Description Initially reported & solution proposed by @corbella83. Newer OpenJDK versions have introduced `List.removeLast` / `List.removeFirst` methods, which haven't existed in JDK before and were provided by Kotlin std lib `kotlin-std`. Android SDK 35 aligns with recent OpenJDK versions & when compiling with SDK 35 the method call is statically resolved to the function from JDK and not to the one from `kotlin-std`. Thus when running on lower version of runtime (<= 34) there is no such method available at runtime (at address resolved in compile time) leading to runtime crash. Section in Android docs describing this: https://developer.android.com/about/versions/15/behavior-changes-15?hl=en#openjdk-api-changes Fixes #2257 ## Changes * Replaced call to `drawingOpList.removeLast` with `drawingOpList.removeAt(drawingOpList.lastIndex)`. * Added comment to ensure no one refactors this code bu accident at some later point. ## Test code and steps to reproduce Bump sdk to 35 in Example / FabricExample & run the application. It won't fail in runtime anymore. ## Checklist - [x] Ensured that CI passes CI fails sometimes with some `reanimated` / `gesture-handler` related reasons: <details><summary>Error message</summary> <p> ``` > Task :react-native-gesture-handler:processDebugAndroidTestManifest FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':react-native-gesture-handler:processDebugAndroidTestManifest'. > Could not resolve all files for configuration ':react-native-gesture-handler:debugAndroidTestRuntimeClasspath'. > Failed to transform hermes-android-0.74.1-debug.aar (com.facebook.react:hermes-android:0.74.1) to match attributes {artifactType=android-manifest, com.android.build.api.attributes.BuildTypeAttr=debug, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}. > Execution failed for JetifyTransform: /home/runner/.gradle/caches/modules-2/files-2.1/com.facebook.react/hermes-android/0.74.1/16e198f2042f7758123b39bba3d5e3d6eb33ba8a/hermes-android-0.74.1-debug.aar. > Java heap space ``` </p> </details> which seem unrelated to the PR, but might indicate either some issue with other lib **or** insufficient java heap size. Co-authored-by: Pau Corbella <corbella83@gmail.com> Co-authored-by: Pau Corbella <corbella83@gmail.com>

@corbella83

…mansion#2258) ## Description Initially reported & solution proposed by @corbella83. Newer OpenJDK versions have introduced `List.removeLast` / `List.removeFirst` methods, which haven't existed in JDK before and were provided by Kotlin std lib `kotlin-std`. Android SDK 35 aligns with recent OpenJDK versions & when compiling with SDK 35 the method call is statically resolved to the function from JDK and not to the one from `kotlin-std`. Thus when running on lower version of runtime (<= 34) there is no such method available at runtime (at address resolved in compile time) leading to runtime crash. Section in Android docs describing this: https://developer.android.com/about/versions/15/behavior-changes-15?hl=en#openjdk-api-changes Fixes software-mansion#2257 ## Changes * Replaced call to `drawingOpList.removeLast` with `drawingOpList.removeAt(drawingOpList.lastIndex)`. * Added comment to ensure no one refactors this code bu accident at some later point. ## Test code and steps to reproduce Bump sdk to 35 in Example / FabricExample & run the application. It won't fail in runtime anymore. ## Checklist - [x] Ensured that CI passes CI fails sometimes with some `reanimated` / `gesture-handler` related reasons: <details><summary>Error message</summary> <p> ``` > Task :react-native-gesture-handler:processDebugAndroidTestManifest FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':react-native-gesture-handler:processDebugAndroidTestManifest'. > Could not resolve all files for configuration ':react-native-gesture-handler:debugAndroidTestRuntimeClasspath'. > Failed to transform hermes-android-0.74.1-debug.aar (com.facebook.react:hermes-android:0.74.1) to match attributes {artifactType=android-manifest, com.android.build.api.attributes.BuildTypeAttr=debug, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}. > Execution failed for JetifyTransform: /home/runner/.gradle/caches/modules-2/files-2.1/com.facebook.react/hermes-android/0.74.1/16e198f2042f7758123b39bba3d5e3d6eb33ba8a/hermes-android-0.74.1-debug.aar. > Java heap space ``` </p> </details> which seem unrelated to the PR, but might indicate either some issue with other lib **or** insufficient java heap size. Co-authored-by: Pau Corbella <corbella83@gmail.com> Co-authored-by: Pau Corbella <corbella83@gmail.com>

github-actions bot added the Missing repro This issue need minimum repro scenario label Jul 19, 2024

github-actions bot added the Platform: Android This issue is specific to Android label Jul 19, 2024

corbella83 mentioned this issue Jul 19, 2024

Fix api35 crash #2256

Closed

8 tasks

github-actions bot added the Missing info The user didn't precise the problem enough label Jul 19, 2024

kkafar self-assigned this Jul 20, 2024

kkafar mentioned this issue Jul 22, 2024

fix(Android): comply to breaking changes in Android SDK 35 #2258

Merged

1 task

kkafar closed this as completed in #2258 Jul 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crashing when updating android to api target 35 #2257

Crashing when updating android to api target 35 #2257

corbella83 commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

corbella83 commented Jul 19, 2024 •

edited

Loading

Crashing when updating android to api target 35 #2257

Crashing when updating android to api target 35 #2257

Comments

corbella83 commented Jul 19, 2024 • edited Loading

Description

Steps to reproduce

Screens version

React Native version

Platforms

JavaScript runtime

Workflow

Architecture

Build type

Device

Device model

Acknowledgements

github-actions bot commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

corbella83 commented Jul 19, 2024 • edited Loading

corbella83 commented Jul 19, 2024 •

edited

Loading

corbella83 commented Jul 19, 2024 •

edited

Loading