fix: Adds dispatch for hiding header #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kacper Kapuściak <39658211+kacperkapusciak@users.noreply.github.com>
WoLewicki
reviewed
Sep 28, 2021
There was a problem hiding this comment.
I think it would be best to extract the new native code into a method and call it there. There is already much code in the viewWillAppear method. This PR should also be tested thoroughly in all kinds of navigation, like swiping, clicking back button, navigating from JS, since these options can return different values.
|
@WoLewicki I added videos before and after |
This reverts commit b57ab36.
WoLewicki
reviewed
Sep 28, 2021
WoLewicki
reviewed
Sep 28, 2021
WoLewicki
approved these changes
Oct 4, 2021
kacperkapusciak
approved these changes
Oct 5, 2021
|
@Ubax which version is this in? |
|
@nandorojo Looking at the commit history, it will be available in the next release. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #996.
More about native issue https://stackoverflow.com/questions/51402566/navigation-bar-issue-when-search-is-active-and-push-to-next-view-controller
Testing
Before:
Screen.Recording.2021-09-28.at.15.16.35.mov
After:
Screen.Recording.2021-09-28.at.15.11.21.mov
Checklist