Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideHeaderIfNecessary for Fabric #1491

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 27, 2022

Description

Added the fix introduced here:

for Fabric.

Changes

  • Moved hideHeaderIfNecessary method to common section
  • Added fix for Fabric: when returning from second screen application would crash due to order of view unmounting (child-first) on Fabric (calling view.reactSubviews[0] would cause application to crash)

Test code and steps to reproduce

Checklist

@kkafar kkafar changed the title @kkafar/hide header if necessary feat: hideHeaderIfNecessary for Fabric Jun 27, 2022
@kkafar kkafar changed the title feat: hideHeaderIfNecessary for Fabric fix: hideHeaderIfNecessary for Fabric Jun 27, 2022
@kkafar kkafar requested a review from WoLewicki June 27, 2022 13:55
@kkafar kkafar marked this pull request as ready for review June 27, 2022 13:55
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment, other than that it looks good. Good job 🎉

ios/RNSScreen.mm Outdated Show resolved Hide resolved
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
@kkafar kkafar merged commit 3df64e7 into main Jun 27, 2022
@kkafar kkafar deleted the @kkafar/hide-header-if-necessary branch June 27, 2022 14:03
@kkafar kkafar mentioned this pull request Aug 13, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants