feat: Screen props: fullScreenSwipeEnabled (1)
#1362
Conversation
kkafar
changed the base branch from
main
to
@kkafar/fabric-rnsscreen-props-base
| private fun logNotAvailable(propName: String) { | ||
| Log.w("RN SCREENS", "$propName prop is not available on Android") | ||
| } |
There was a problem hiding this comment.
I think this should be moved out from the class to some kind of utils. This time I followed example of ScreenStackHeaderConfigViewManager
| typedef NS_ENUM(NSInteger, RNSScreenSwipeDirection) { | ||
| RNSScreenSwipeDirectionHorizontal, | ||
| RNSScreenSwipeDirectionVertical, | ||
| }; |
There was a problem hiding this comment.
I moved such enum types to the external header file in one of following PRs
|
|
||
| - (void)didMoveToWindow | ||
| { | ||
| if (self.window != nil && ![self isMountedUnderScreenOrReactRoot]) { |
There was a problem hiding this comment.
It was added for proper gesture handling in modals and it would be good to check if it works correctly there after we merge modal stackPresentations. It will be good to test on example provided in #784
|
|
||
| if (parent != nil) { | ||
| RCTSurfaceTouchHandler *touchHandler = [parent performSelector:@selector(touchHandler)]; | ||
| [touchHandler setEnabled:NO]; |
There was a problem hiding this comment.
Is calling those 2 methods the same as this:
react-native-screens/ios/RNSScreenStack.m
Line 600 in 8442950
There was a problem hiding this comment.
It should be. The thing is, that in new counterpart of RCTTouchHandler -- RCTSurfaceTouchHandler the cancel method became private, but it has the same impl as before (old impl, new impl).
PS. Tested -- seems to work properly
Should I put a test screen for this in FabricTestExample or maybe the test exists somewhere already? 🤔
kkafar
force-pushed
the
@kkafar/screen-props-fullScreenSwipeEnabled
branch
from
ae55c29
to
92c1eef
Compare
kkafar
changed the base branch from
@kkafar/fabric-rnsscreen-props-base
to
main
android/src/paper See: #1328
kkafar
force-pushed
the
@kkafar/screen-props-fullScreenSwipeEnabled
branch
from
92c1eef
to
a8019a8
Compare
Description
Support screen props on Fabric
Part of stack PR:
fullScreenSwipeEnabled(1) #1362screenOrientation(3) #1364stackPresentation&stackAnimation(4) #1365Changes
Test code and steps to reproduce
Checklist