feat: Screen props: Window traits (2) #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kkafar
changed the title
statusBar*statusBar* (2)
This was referenced Mar 18, 2022
WoLewicki
reviewed
Mar 18, 2022
| @@ -378,6 +378,8 @@ - (void)invalidate | |||
|
|
|||
| @end | |||
|
|
|||
| #pragma mark - RNSScreen | |||
There was a problem hiding this comment.
Just for ease of navigation in file with implementations of 2+ classes, should I remove it?
| @@ -31,6 +32,13 @@ - (instancetype)initWithFrame:(CGRect)frame | |||
| static const auto defaultProps = std::make_shared<const RNSScreenProps>(); | |||
| _props = defaultProps; | |||
| _controller = [[RNSScreenController alloc] initWithView:self]; | |||
| // TODO: use default props (?) | |||
There was a problem hiding this comment.
Yeah, I think we can leave just _gestureEnabled
| @@ -194,10 +241,31 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const & | |||
| const auto &oldScreenProps = *std::static_pointer_cast<const RNSScreenProps>(_props); | |||
| const auto &newScreenProps = *std::static_pointer_cast<const RNSScreenProps>(props); | |||
|
|
|||
| [super updateProps:props oldProps:oldProps]; | |||
| [self setFullScreenSwipeEnabled:newScreenProps.fullScreenSwipeEnabled]; | |||
There was a problem hiding this comment.
Why do you sometimes just set the new prop and sometimes you check the old ones before setting new one?
There was a problem hiding this comment.
The props surrounded with if-statement have some additional logic in their setters, no reason to run it when the prop value is not changed.
android/src/paper See: #1328
kkafar
force-pushed
the
@kkafar/screen-props-fullScreenSwipeEnabled
branch
from
ae55c29
to
92c1eef
Compare
This allows to share those types between old and new architecture
Required to enable status bar modifications
kkafar
force-pushed
the
@kkafar/screen-props-statusBar
branch
from
38a6ed2
to
310339c
Compare
WoLewicki
reviewed
Mar 29, 2022
kkafar
changed the title
statusBar* (2)
kkafar
force-pushed
the
@kkafar/screen-props-statusBar
branch
from
a6cca1d
to
9438df7
Compare
kkafar
force-pushed
the
@kkafar/screen-props-fullScreenSwipeEnabled
branch
from
92c1eef
to
a8019a8
Compare
Base automatically changed from
@kkafar/screen-props-fullScreenSwipeEnabled
to
main
April 1, 2022 09:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support screen props on Fabric
Part of stack PR:
fullScreenSwipeEnabled(1) #1362screenOrientation(3) #1364stackPresentation&stackAnimation(4) #1365Changes
Test code and steps to reproduce
status bar props
screen orientation
Checklist