Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape html #24

Closed
wants to merge 1 commit into from
Closed

fix: escape html #24

wants to merge 1 commit into from

Conversation

znck
Copy link

@znck znck commented Mar 18, 2018

No description provided.

@znck znck mentioned this pull request Mar 18, 2018
Closed
@paulirish
Copy link
Collaborator

Thanks.
btw, the base64 example here reproduces the bug.

@paulirish paulirish mentioned this pull request Mar 19, 2018
Closed
paulirish
paulirish requested changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like this fix mangles HTML of other examples..

see this on the typescript example:
image

I have an alternative fix in #25

@paulirish paulirish mentioned this pull request Mar 19, 2018
Merged
@paulirish paulirish closed this in f373102 Mar 19, 2018
@znck znck deleted the patch-1 branch March 19, 2018 02:35
@znck
Copy link
Author

znck commented Mar 19, 2018

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znck @paulirish