This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Improve Rpc inflation tooling #10309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
rpc-improve-inflation
branch
3 times, most recently
from
bff1ec1 to
05f54e6
Compare
CriesofCarrots
force-pushed
the
rpc-improve-inflation
branch
from
05f54e6 to
1890bb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #10309 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 288 288
Lines 66906 66982 +76
=========================================
+ Hits 54433 54489 +56
- Misses 12473 12493 +20 |
mvines
reviewed
May 29, 2020
CriesofCarrots
force-pushed
the
rpc-improve-inflation
branch
from
1890bb6 to
d8ca31e
Compare
mvines
previously approved these changes
May 29, 2020
| @@ -635,33 +636,59 @@ curl -X POST -H "Content-Type: application/json" -d '{"jsonrpc":"2.0","id":1, "m | |||
| {"jsonrpc":"2.0","result":{"identity": "2r1F4iWqVcb8M1DbAjQuFpebkQHY9hcVU4WuW2DJBppN"},"id":1} | |||
| ``` | |||
|
|
|||
| ### getInflation | |||
There was a problem hiding this comment.
Can you please mark getInflation as deprecated in core/src/rpc.rs too, so future readers know why that endpoint is no longer documented
There was a problem hiding this comment.
Currently, this pr removes the getInflation endpoint entirely. My thinking was that there are unlikely to be downstream users, since no inflation on mainnet-beta, and only very new to testnet.
Should I restore?
There was a problem hiding this comment.
Ah, I totally missed that in the diff. Yanking it seems fine, I agree
CriesofCarrots
force-pushed
the
rpc-improve-inflation
branch
from
d8ca31e to
e526bba
Compare
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49) # Conflicts: # core/Cargo.toml # core/src/rpc.rs # genesis-programs/src/lib.rs # runtime/src/bank.rs
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49) # Conflicts: # core/Cargo.toml # runtime/src/bank.rs
CriesofCarrots
pushed a commit
that referenced
this pull request
May 29, 2020
CriesofCarrots
added a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49)
CriesofCarrots
added a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49)
CriesofCarrots
added a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49)
CriesofCarrots
added a commit
that referenced
this pull request
May 29, 2020
automerge (cherry picked from commit b563b49)
solana-grimes
pushed a commit
that referenced
this pull request
May 29, 2020
solana-grimes
pushed a commit
that referenced
this pull request
May 30, 2020
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getInflationendpoint returns essentially an inflation governor, not any information about current inflation rates. This forces user to re-implement the same calculator methods that we have in the sdk/inflation module.Summary of Changes
getInflationGovernorendpoint that returns the inflation governor datagetInflationRateendpoint that calculates the current inflation for an epoch (default, current epoch)Fixes #10094
Fixes #10092