replaces once_cell::sync::OnceCell with std::sync::OnceLock #33140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
rm-once-cell
branch
7 times, most recently
from
a4c7695
to
dd9b82f
Compare
behzadnouri
force-pushed
the
rm-once-cell
branch
3 times, most recently
from
6d1706f
to
1948553
Compare
std::sync::OnceLock has become stable since rust 1.70.0 and there is no longer a need for an external crate dependency.
behzadnouri
force-pushed
the
rm-once-cell
branch
from
1948553
to
700ef33
Compare
ryoqun
reviewed
Oct 4, 2023
| @@ -555,9 +555,3 @@ impl<O: AbiEnumVisitor, E: AbiEnumVisitor> AbiEnumVisitor for Result<O, E> { | |||
| digester.create_child() | |||
| } | |||
| } | |||
|
|
|||
| impl<T: AbiExample> AbiExample for once_cell::sync::OnceCell<T> { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
std::sync::OnceLockhas become stable since rust 1.70.0 and there is no longer a need for an external crate dependency.Summary of Changes
replaced
once_cell::sync::OnceCellwithstd::sync::OnceLock.