Define generic AbiExample for OnceLock #33520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-test-sbf (governance/addin-mock/program, governance/program):
error[E0658]: use of unstable library feature 'once_cell'
--> src/abi_example.rs:559:36
|
559 | impl<T: AbiExample> AbiExample for std::sync::OnceLock<T> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <rust-lang/rust#74465> for more information
= help: add `#![feature(once_cell)]` to the crate attributes to enable
Codecov Report
@@ Coverage Diff @@
## master #33520 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 802 802
Lines 217872 217863 -9
=======================================
+ Hits 178144 178184 +40
+ Misses 39728 39679 -49 |
behzadnouri
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
see:
https://discord.com/channels/428295358100013066/1070815022604877915/1149026378323345469
for why this was removed.
Seems like toolchain has been updated since then.
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Oct 6, 2023
* Define generic AbiExample for OnceLock
* Guard with cfg...
cargo-test-sbf (governance/addin-mock/program, governance/program):
error[E0658]: use of unstable library feature 'once_cell'
--> src/abi_example.rs:559:36
|
559 | impl<T: AbiExample> AbiExample for std::sync::OnceLock<T> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <rust-lang/rust#74465> for more information
= help: add `#![feature(once_cell)]` to the crate attributes to enable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
i found generic
AbiExamplecan be implemented while working on #33501.seems #33140 (comment) removed generic impl for
OnceCell, and replaced it with manual concrete AbiExample impls.Summary of Changes
Define generic AbiExample for OnceLock for ease of use of frozen abi.
cc: @apfitzge