stat for time spent copying generate index contents #33187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
sp10
branch
4 times, most recently
from
e49029d
to
a02f41e
Compare
Codecov Report
@@ Coverage Diff @@
## master #33187 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 786 786
Lines 211596 211606 +10
=======================================
+ Hits 173777 173851 +74
+ Misses 37819 37755 -64 |
brooksprumo
reviewed
Sep 8, 2023
| @@ -516,6 +517,7 @@ impl BucketMapHolderStats { | |||
| .swap(0, Ordering::Relaxed), | |||
| i64 | |||
| ), | |||
| ("copy_us", self.copy_us.swap(0, Ordering::Relaxed), i64), | |||
There was a problem hiding this comment.
Wdyt about a more descriptive name for this datapoint? Would startup_insert_us work? Or maybe startup_copy_us?
There was a problem hiding this comment.
yeah, moved these to generate_index stats. Reduces overall noise.
brooksprumo
reviewed
Sep 8, 2023
| @@ -68,6 +70,8 @@ pub struct BucketMapHolder<T: IndexValue, U: DiskIndexValue + From<T> + Into<T>> | |||
| /// Note startup is an optimization and is not required for correctness. | |||
| startup: AtomicBool, | |||
| _phantom: PhantomData<T>, | |||
|
|
|||
| pub(crate) startup_stats: Arc<StartupStats>, | |||
There was a problem hiding this comment.
Why are the startup stats also added here? Is this needed? Or maybe for a future use?
There was a problem hiding this comment.
because the holder holds the accessible one. it gets retrieved from here.
There was a problem hiding this comment.
each bin holds a reference to the common one. I guess they could all reference the common one instead.
brooksprumo
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Speeding up generate index/startup time.
We spend a ton of time copying data.
Summary of Changes
Add a metric for that time.
Fixes #