Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TieredStorage] Include Hot Account in StoredAccountMeta and ReadableAccount #33544

Merged
merged 2 commits into from
Oct 6, 2023
Merged

[TieredStorage] Include Hot Account in StoredAccountMeta and ReadableAccount #33544

merged 2 commits into from
Oct 6, 2023

Conversation

yhchiang-sol
Copy link
Contributor

@yhchiang-sol yhchiang-sol commented Oct 5, 2023 •
edited
Loading

Problem

All account storage formats are required to implement both StoredAccountMeta
and ReadableAccount, but the implementation for the hot account format is missing.

Summary of Changes

This PR includes hot account format into StoredAccountMeta and ReadableAccount
enum. This will allow the TieredStorageReader in the future PRs to return hot account
format in its get_account implementation.

@yhchiang-sol yhchiang-sol marked this pull request as draft October 5, 2023 17:55
@yhchiang-sol yhchiang-sol force-pushed the acc-meta-hot branch 2 times, most recently from c75aae1 to f519ed0 Compare October 5, 2023 18:45
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #33544 (9093450) into master (c66af12) will decrease coverage by 0.1%.
Report is 23 commits behind head on master.
The diff coverage is 16.0%.

@@            Coverage Diff            @@
##           master   #33544     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         805      805             
  Lines      218111   218181     +70     
=========================================
+ Hits       178323   178357     +34     
- Misses      39788    39824     +36

@yhchiang-sol yhchiang-sol marked this pull request as ready for review October 6, 2023 07:45
brooksprumo
brooksprumo reviewed Oct 6, 2023
View reviewed changes
accounts-db/src/account_storage/meta.rs Show resolved Hide resolved
accounts-db/src/account_storage/meta.rs Outdated Show resolved Hide resolved
accounts-db/src/account_storage/meta.rs Outdated Show resolved Hide resolved
accounts-db/src/account_storage/meta.rs Outdated Show resolved Hide resolved
accounts-db/src/account_storage/meta.rs Outdated Show resolved Hide resolved
accounts-db/src/append_vec.rs Show resolved Hide resolved
brooksprumo
brooksprumo approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo mentioned this pull request Oct 6, 2023
Merged
@yhchiang-sol yhchiang-sol merged commit ecb1f8a into solana-labs:master Oct 6, 2023
16 checks passed
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhchiang-sol @brooksprumo