Removes write version from tiered storage #33566
Merged
+70
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33566 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 805 805
Lines 218246 218180 -66
=========================================
- Hits 178436 178358 -78
- Misses 39810 39822 +12 |
|
I'll rebase this one once #33544 is merged. I'm guessing there will be merge conflicts I'll need to resolve—I don't want to break the build! |
yhchiang-sol
previously approved these changes
Oct 6, 2023
brooksprumo
force-pushed
the
tiered-storage/remove-write-version
branch
from
a87a75d
to
7df960a
Compare
|
Force-pushed due to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
"Write version" is a relic when we appended to AppendVecs and supported multiple AppendVecs per slot. The write version was used to identify the correct version of each account to use (i.e. pick the version with the highest write version).
With the new tiered storage, we'll always perform writing the full file in one shot, and appends will not be allowed. This means there will only ever be one account per file. Additionally, we only allow one accounts storage file per slot, so later slots hold more recent account information.
This means the write version is not needed for the new tiered storage format.
Summary of Changes
Remove write version from tiered storage.