Output BankHashDetails file when leader drops its' own block

[steviez]

Problem

Currently, the file is generated when a node drops a block that was
produced by another node. However, it would also be beneficial to see
the account state when a node drops its' own block.

Summary of Changes

Output the file in this additional failure codepath

Note that the debug file gets generated when we are not the leader via ReplayStage::purge_unconfirmed_duplicate_slot():

solana/core/src/replay_stage.rs

Line 1510 in e425c1a

let _ = bank_hash_details::write_bank_hash_details_file(&bank);

[codecov]

Codecov Report

Merging #34256 (4ef6b52) into master (b741c9c) will increase coverage by 0.0%.
Report is 20 commits behind head on master.
The diff coverage is 79.5%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #34256   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         819      819           
  Lines      219387   219406   +19     
=======================================
+ Hits       179690   179745   +55     
+ Misses      39697    39661   -36     

[AshwinSekar]

LGTM. if we're backporting the regular bank hash details, I vote that we should also backport this pr as it is extremely useful in debugging.

[steviez]

LGTM. if we're backporting the regular bank hash details, I vote that we should also backport this pr as it is extremely useful in debugging.

Agreed, that is currently a work in progress 😉 for v1.16. I'm going to add the v1.17 label to this PR for now; will make sure to get buy in from Will and/or Trent for that one before submitting

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

[mergify]

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.