v1.17: Output BankHashDetails file when leader drops its' own block (backport of #34256) #34275
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Currently, the file is generated when a node drops a block that was produced by another node. However, it would also be beneficial to see the account state when a node drops its' own block. Output the file in this additional failure codepath (cherry picked from commit 935e06f)
|
Going to let CI run - will then tag Ashwin / Will / Trent as reviewers
I know we're being stingy with backports at the moment for both branches; however, this commit is very beneficial in debugging, both in time savings as well as giving us the potential to view state in a divergent node that may not recreate itself in attempts to reproduce. I thing we should definitely BP this for v1.17, I'd argue for v1.16 too but that is dependent on #34257 getting approval |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34275 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 803 803
Lines 218021 218030 +9
=======================================
+ Hits 178427 178466 +39
+ Misses 39594 39564 -30 |
There was a problem hiding this comment.
The change looks good to me.
My personal opinion is that we should backport this to 1.16 as well in case there are anymore mismatches before the upgrade to 1.17 happens in January. The bank hash details are invaluable to debugging consensus failures that are not easily reproducible.
This is an automatic backport of pull request #34256 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com