Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split cargo-clippy into stable and nightly #34566

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Dec 21, 2023

Problem

context: https://discord.com/channels/428295358100013066/560503042458517505/1187442157326450780

Summary of Changes

  • split cargo-clippy into stable and nightly

btw, if we still feel this one too slow, I can split them into smaller pieces (but will be a little bit hardcoded)
or we need a better macos runner 😢

@yihau yihau marked this pull request as ready for review December 21, 2023 18:32
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split code looks fine. Should probably put the mergify changes in here too, though, since you're changing the job names.

@yihau
Copy link
Member Author

yihau commented Dec 21, 2023

okay! updated! just had a quick look to those code. I guess they can be backported directly 🤞

@yihau yihau added v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17 labels Dec 21, 2023
Copy link
Contributor

mergify bot commented Dec 21, 2023

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link
Contributor

mergify bot commented Dec 21, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@yihau yihau merged commit 5247be1 into solana-labs:master Dec 21, 2023
16 of 18 checks passed
@yihau yihau deleted the split-macos-clippy branch December 21, 2023 19:28
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
* ci: split cargo-clippy into stable and nightly

* ci: update mergify

(cherry picked from commit 5247be1)

# Conflicts:
#	.mergify.yml
#	scripts/cargo-clippy.sh
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
* ci: split cargo-clippy into stable and nightly

* ci: update mergify

(cherry picked from commit 5247be1)

# Conflicts:
#	.mergify.yml
#	scripts/cargo-clippy.sh
mergify bot added a commit that referenced this pull request Dec 21, 2023
…4566) (#34569)

* ci: split cargo-clippy into stable and nightly (#34566)

* ci: split cargo-clippy into stable and nightly

* ci: update mergify

(cherry picked from commit 5247be1)

# Conflicts:
#	.mergify.yml
#	scripts/cargo-clippy.sh

* fix conflict

---------

Co-authored-by: Yihau Chen <a122092487@gmail.com>
Co-authored-by: yihau <yihau.chen@icloud.com>
mergify bot added a commit that referenced this pull request Dec 21, 2023
…4566) (#34568)

* ci: split cargo-clippy into stable and nightly (#34566)

* ci: split cargo-clippy into stable and nightly

* ci: update mergify

(cherry picked from commit 5247be1)

# Conflicts:
#	.mergify.yml
#	scripts/cargo-clippy.sh

* fix conflict

* fix clippy rule

---------

Co-authored-by: Yihau Chen <a122092487@gmail.com>
Co-authored-by: yihau <yihau.chen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants