Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces fs-err in snapshot_bank_utils.rs #34861

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Replaces fs-err in snapshot_bank_utils.rs #34861

merged 1 commit into from
Jan 22, 2024

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 19, 2024 •
edited
Loading

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838

Summary of Changes

Replace fs_err in snapshot_bank_utils.rs with std::fs

Note, all the uses of fs-err here are in tests, and are always unwrapped or asserted. So nothing that'll be displayed/logged for a user.

@brooksprumo brooksprumo self-assigned this Jan 19, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 19, 2024 20:04
steviez
steviez approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brooksprumo brooksprumo merged commit 90933fe into solana-labs:master Jan 22, 2024
35 checks passed
@brooksprumo brooksprumo deleted the fs-err/runtime/snap-bank-utils branch January 22, 2024 04:09
@brooksprumo brooksprumo mentioned this pull request Jan 22, 2024
Merged
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @steviez