Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces fs-err in snapshot_utils tests #34870

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838

Summary of Changes

Replace fs_err in snapshot_utils.rs with std::fs

Note, all the uses of fs-err here are in tests, and are always unwrapped or asserted. So nothing that'll be displayed/logged for a user.

@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo
Copy link
Contributor Author

This is very similar to #34861, but that PR was for snapshot_bank_utils.rs, and this is for snapshot_utils.rs.

@brooksprumo brooksprumo marked this pull request as ready for review January 22, 2024 04:43
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9bfb60) 81.7% compared to head (50477d2) 81.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34870   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         826      826           
  Lines      223371   223371           
=======================================
  Hits       182578   182578           
  Misses      40793    40793           

@brooksprumo brooksprumo merged commit b78d417 into solana-labs:master Jan 22, 2024
35 checks passed
@brooksprumo brooksprumo deleted the snap/errors/utils-tests branch January 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants