Optimize rate limit hash calculation #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
kdorosh
removed
the
keep pr updated
|
Issues linked to changelog: |
yuval-k
changed the title
|
Visit the preview URL for this PR (updated for commit 7ad218d): https://gloo-edge--pr7198-hash-ratelimits-10mhp7dn.web.app (expires Fri, 30 Sep 2022 19:14:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
note: the test fail is due to data race that is fixed in a different PR |
kdorosh
approved these changes
Sep 23, 2022
kdorosh
added
the
keep pr updated
kdorosh
pushed a commit
that referenced
this pull request
Sep 23, 2022
* gencode with unrelease solokit * update solokit * codegen * changelog * empty * Adding changelog file to new location * Deleting changelog file from old location Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io>
8 tasks
soloio-bulldozer bot
added a commit
that referenced
this pull request
Sep 23, 2022
* Resolve various data races in translation and validation (#7207) * Add lock for translation * Share translator to reuse caches * Add lock for sanitizers * Add note for devs * No need to be too safe before we need it * No need for RWMutex * Add changelog * Avoid global scheme in broken skv2 function * Need to use global scheme, but register it before race can happen * Import the right scheme * Fix data race in with serving xds * Fix data race with status reporter * Adding changelog file to new location * Deleting changelog file from old location * Lock on validator sync * Remove extra lock * Add more locks * Need write lock * Copy write namespaces to avoid race * Update changelog * Revert "Fix data race with status reporter" This reverts commit 256767e. * Revert "Fix data race in with serving xds" This reverts commit 7df16e1. Co-authored-by: changelog-bot <changelog-bot> * Fix merge * Optimize rate limit hash calculation (#7198) * gencode with unrelease solokit * update solokit * codegen * changelog * empty * Adding changelog file to new location * Deleting changelog file from old location Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io> * Use new hashstructure (#7227) * update protoc-gen-ext * code gen * remove remaining usages * make update-licenses * changelog * update solo-apis 9746539fc625fed45d1d146c4e0c1359e70f8036 - gloo-edge-safe-hasher * go mod tidy * fix merge solo kit v0.30.4 * Go mod tidy Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io> * Codegen * Consolidate changelogs * Prefer fix changelog type Co-authored-by: Yuval Kohavi <yuval.kohavi@gmail.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.