-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.12] Backport data race and speed optimizations #7230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add lock for translation * Share translator to reuse caches * Add lock for sanitizers * Add note for devs * No need to be too safe before we need it * No need for RWMutex * Add changelog * Avoid global scheme in broken skv2 function * Need to use global scheme, but register it before race can happen * Import the right scheme * Fix data race in with serving xds * Fix data race with status reporter * Adding changelog file to new location * Deleting changelog file from old location * Lock on validator sync * Remove extra lock * Add more locks * Need write lock * Copy write namespaces to avoid race * Update changelog * Revert "Fix data race with status reporter" This reverts commit 256767e. * Revert "Fix data race in with serving xds" This reverts commit 7df16e1. Co-authored-by: changelog-bot <changelog-bot>
* gencode with unrelease solokit * update solokit * codegen * changelog * empty * Adding changelog file to new location * Deleting changelog file from old location Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io>
* update protoc-gen-ext * code gen * remove remaining usages * make update-licenses * changelog * update solo-apis 9746539fc625fed45d1d146c4e0c1359e70f8036 - gloo-edge-safe-hasher * go mod tidy * fix merge solo kit v0.30.4 * Go mod tidy Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io>
github-actions
bot
added
the
keep pr updated
signals bulldozer to keep pr up to date with base branch
label
Sep 23, 2022
kdorosh
changed the title
Backport race speed fixes
[v1.12] Backport data race and speed optimizations
Sep 23, 2022
sam-heilbron
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backports of:
Checklist:
make -B install-go-tools generated-code
to ensure there will be no code diffBOT NOTES:
resolves #7202
resolves solo-io/skv2#375
resolves #7213
resolves #7209
resolves #7210