Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.12] Backport data race and speed optimizations #7230

Merged
merged 7 commits into from
Sep 23, 2022

Conversation

kdorosh
Copy link
Contributor

@kdorosh kdorosh commented Sep 23, 2022

Description

backports of:

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #7202
resolves solo-io/skv2#375
resolves #7213
resolves #7209
resolves #7210

Kevin Dorosh and others added 6 commits September 23, 2022 16:20
* Add lock for translation

* Share translator to reuse caches

* Add lock for sanitizers

* Add note for devs

* No need to be too safe before we need it

* No need for RWMutex

* Add changelog

* Avoid global scheme in broken skv2 function

* Need to use global scheme, but register it before race can happen

* Import the right scheme

* Fix data race in with serving xds

* Fix data race with status reporter

* Adding changelog file to new location

* Deleting changelog file from old location

* Lock on validator sync

* Remove extra lock

* Add more locks

* Need write lock

* Copy write namespaces to avoid race

* Update changelog

* Revert "Fix data race with status reporter"

This reverts commit 256767e.

* Revert "Fix data race in with serving xds"

This reverts commit 7df16e1.

Co-authored-by: changelog-bot <changelog-bot>
* gencode with unrelease solokit

* update solokit

* codegen

* changelog

* empty

* Adding changelog file to new location

* Deleting changelog file from old location

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: changelog-bot <changelog-bot>
Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io>
* update protoc-gen-ext

* code gen

* remove remaining usages

* make update-licenses

* changelog

* update solo-apis 9746539fc625fed45d1d146c4e0c1359e70f8036 - gloo-edge-safe-hasher

* go mod tidy

* fix merge solo kit v0.30.4

* Go mod tidy

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Kevin Dorosh <kevin.dorosh@solo.io>
@kdorosh kdorosh requested a review from a team as a code owner September 23, 2022 20:25
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Sep 23, 2022
@kdorosh kdorosh changed the title Backport race speed fixes [v1.12] Backport data race and speed optimizations Sep 23, 2022
@solo-changelog-bot
Copy link

Issues linked to changelog:
#7202
solo-io/skv2#375
#7213
#7209
#7210
#7169

Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soloio-bulldozer soloio-bulldozer bot merged commit 7edf24a into v1.12.x Sep 23, 2022
@soloio-bulldozer soloio-bulldozer bot deleted the backport_race_speed_fixes branch September 23, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants