Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Make SonataEasyExtends optional #171

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jun 12, 2020

Subject

I am targeting this branch, because this is BC.

Part of: sonata-project/dev-kit#750

SonataEasyExtends is deprecated but it is used on many bundles, this makes it optional. This change is BC because if the user does not change anything it will continue using the deprecated code but with a message.

Changelog

### Changed
- SonataEasyExtendsBundle is now optional, using SonataDoctrineBundle is preferred
### Deprecated
- Using SonataEasyExtendsBundle to add Doctrine mapping information

To do

  • Update the documentation;
  • Add an upgrade note.

@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch 7 times, most recently from 8869e02 to 018af45 Compare June 15, 2020 17:02
@jordisala1991 jordisala1991 marked this pull request as ready for review June 15, 2020 17:05
greg0ire
greg0ire previously approved these changes Jun 15, 2020
@greg0ire
Copy link
Contributor

Why the huge drop in coverage?

@jordisala1991
Copy link
Member Author

the extension is not tested, I will try to add some test, those PR will be huge. I saw the recipes from flex and contain the Orm relations, so I will need to change them too, and create the missing ones.

@greg0ire
Copy link
Contributor

🤔 so is that PR finished or do you plan to do this later?

@jordisala1991
Copy link
Member Author

It is not finished, I will change it to draft again. And it cannot be merged if the bug on extensions is not merged.

@jordisala1991 jordisala1991 marked this pull request as draft June 15, 2020 17:26
@jordisala1991
Copy link
Member Author

Why the huge drop in coverage?

The drop in coverage is due to not testing the deprecated easy extends code

@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch 6 times, most recently from d6886a1 to 5d5128d Compare June 28, 2020 11:06
@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch from 5d5128d to 636a091 Compare July 4, 2020 06:59
@jordisala1991
Copy link
Member Author

Blocked by: #173 too

@SonataCI
Copy link
Collaborator

SonataCI commented Jul 4, 2020

Could you please rebase your PR and fix merge conflicts?

@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch from 636a091 to cf2d5b1 Compare July 4, 2020 17:34
@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch from cf2d5b1 to 8915db4 Compare July 21, 2020 18:17
@jordisala1991 jordisala1991 marked this pull request as ready for review July 21, 2020 18:19
@jordisala1991 jordisala1991 requested review from core23 and a team July 21, 2020 18:34
@jordisala1991 jordisala1991 force-pushed the feature/make-easy-extends-optional branch from 8915db4 to fa0231b Compare July 25, 2020 06:46
@@ -1,2 +1,10 @@
UPGRADE 1.x
===========

UPGRADE FROM 1.x to 1.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to remember this while releasing. Would be great to have a keyword and have the release tool warn us that we need to do something.

greg0ire
greg0ire previously approved these changes Jul 25, 2020
@greg0ire greg0ire dismissed stale reviews from core23 and themself July 25, 2020 09:45

Awaiting clarification on #171 (comment)

@greg0ire greg0ire merged commit 14b280b into sonata-project:1.x Jul 25, 2020
@greg0ire
Copy link
Contributor

Thanks @jordisala1991 !

@jordisala1991 jordisala1991 deleted the feature/make-easy-extends-optional branch July 25, 2020 10:08

Check `packagist <https://packagist.org/packages/sonata-project/article-bundle>`_
for existing versions.
* `SonataDoctrineOrmAdminBundle <https://sonata-project.org/bundles/doctrine-orm-admin>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this section must be updated in order to show the remaining persistence bundles.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left only the implemented ones for the ArticleBundle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants