-
-
Notifications
You must be signed in to change notification settings - Fork 25
Make SonataEasyExtends optional #171
Make SonataEasyExtends optional #171
Conversation
8869e02
to
018af45
Compare
Why the huge drop in coverage? |
the extension is not tested, I will try to add some test, those PR will be huge. I saw the recipes from flex and contain the Orm relations, so I will need to change them too, and create the missing ones. |
🤔 so is that PR finished or do you plan to do this later? |
It is not finished, I will change it to draft again. And it cannot be merged if the bug on extensions is not merged. |
68228d8
to
9c5bfe1
Compare
The drop in coverage is due to not testing the deprecated easy extends code |
d6886a1
to
5d5128d
Compare
5d5128d
to
636a091
Compare
Blocked by: #173 too |
Could you please rebase your PR and fix merge conflicts? |
636a091
to
cf2d5b1
Compare
cf2d5b1
to
8915db4
Compare
8915db4
to
fa0231b
Compare
@@ -1,2 +1,10 @@ | |||
UPGRADE 1.x | |||
=========== | |||
|
|||
UPGRADE FROM 1.x to 1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to remember this while releasing. Would be great to have a keyword and have the release tool warn us that we need to do something.
Awaiting clarification on #171 (comment)
Thanks @jordisala1991 ! |
|
||
Check `packagist <https://packagist.org/packages/sonata-project/article-bundle>`_ | ||
for existing versions. | ||
* `SonataDoctrineOrmAdminBundle <https://sonata-project.org/bundles/doctrine-orm-admin>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this section must be updated in order to show the remaining persistence bundles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left only the implemented ones for the ArticleBundle
Subject
I am targeting this branch, because this is BC.
Part of: sonata-project/dev-kit#750
SonataEasyExtends is deprecated but it is used on many bundles, this makes it optional. This change is BC because if the user does not change anything it will continue using the deprecated code but with a message.
Changelog
To do