Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Fix Compatibility with Form Extensions #173

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jul 4, 2020

Subject

I am targeting this branch, because this is BC.

This was missed during @wbloszyk PRs because the dependency between this and CoreBundle was not explicit

Changelog

### Removed
- SonataCoreBundle dependencies
- Support for Symfony < 4.4

@jordisala1991 jordisala1991 requested a review from a team July 4, 2020 07:06
@jordisala1991 jordisala1991 mentioned this pull request Jul 4, 2020
2 tasks
core23
core23 previously approved these changes Jul 4, 2020
VincentLanglet
VincentLanglet previously approved these changes Jul 4, 2020
wbloszyk
wbloszyk previously approved these changes Jul 4, 2020
@jordisala1991 jordisala1991 dismissed stale reviews from wbloszyk, VincentLanglet, and core23 via 7ccf28e July 4, 2020 08:12
@jordisala1991 jordisala1991 force-pushed the hotfix/compatibility-with-form-extensions branch from 2c3122d to 7ccf28e Compare July 4, 2020 08:12
@jordisala1991 jordisala1991 requested review from core23, VincentLanglet and a team July 4, 2020 08:25
@jordisala1991
Copy link
Member Author

Had to bump to sf 4.4 and php 7.2 too, in order to get the prefer lowest build runing

@VincentLanglet VincentLanglet merged commit 00bdd49 into sonata-project:1.x Jul 4, 2020
@jordisala1991 jordisala1991 deleted the hotfix/compatibility-with-form-extensions branch July 4, 2020 11:44
@PierreEkino
Copy link

Is it possible to have a release for it ? Thanks a lot 👍

@wbloszyk
Copy link
Member

wbloszyk commented Jul 7, 2020

@greg0ire Can you release it?

@qsomazzi
Copy link
Member

@sonata-project/release-managers little update on this, can we have a release please ?

@VincentLanglet
Copy link
Member

Sorry, I'm on it #175

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants