Feature/avoid image copy #42
Conversation
ProgHunter
requested review from
wtang-8,
thecanadianroot,
Kam0ss and
Ismedrasor
.vscode/settings.json
Outdated
| @@ -6,5 +6,6 @@ | |||
| "python.analysis.extraPaths": [ | |||
| "/home/sonia/base_lib_ws/devel/lib/python2.7/dist-packages", | |||
| "/opt/ros/melodic/lib/python2.7/dist-packages" | |||
| ] | |||
| ], | |||
| "cmake.configureOnOpen": false | |||
There was a problem hiding this comment.
Should I delete that ?
There was a problem hiding this comment.
No idea what this is...
| @@ -118,6 +121,8 @@ namespace proc_image_processing { | |||
| ROS_ERROR("[FILTERCHAIN %s ], Error in image processing: %s", name_.c_str(), e.what()); | |||
| }; | |||
| } | |||
| // Uncomment with the timer to see filterchain performance | |||
| //ROS_INFO("Filterchain exec time: %f", timer.getExecutionTime()); | |||
There was a problem hiding this comment.
Should I let this ?
There was a problem hiding this comment.
Non, ça bloat le code, mais ça pourrait être bien d'ajouter un debug pour chaque filter qu'on peut activer quand on test et que ça shoot le temps de performance
.vscode/settings.json
Outdated
| @@ -6,5 +6,6 @@ | |||
| "python.analysis.extraPaths": [ | |||
| "/home/sonia/base_lib_ws/devel/lib/python2.7/dist-packages", | |||
| "/opt/ros/melodic/lib/python2.7/dist-packages" | |||
| ] | |||
| ], | |||
| "cmake.configureOnOpen": false | |||
There was a problem hiding this comment.
No idea what this is...
README.md
Outdated
| @@ -125,6 +125,23 @@ TODO document how to run this module with VSCode | |||
| - `ctrl+shift+p` | |||
| - Type `ROS: Start Core` (command id: `ros.startCore`) | |||
|
|
|||
| - Manage and execute filterchains with bags from telemetry: | |||
There was a problem hiding this comment.
Maybe faire une section pour rouler les bags au lieu de mettre ça dans la section pour vscode?
| @@ -22,15 +22,15 @@ filters: | |||
| value: 17 | |||
There was a problem hiding this comment.
Mmmmh normalement dans un yaml tu peux pas avoir 2 fois la même key dans un item (2x value ici)
There was a problem hiding this comment.
nvm, github being github
| @@ -9,6 +9,29 @@ | |||
|
|
|||
| namespace proc_image_processing { | |||
|
|
|||
| class ParallelCABF : public cv::ParallelLoopBody { | |||
There was a problem hiding this comment.
On voulait pas extract ça dans une classe abstraite pour l'utiliser ailleurs?
| @@ -118,6 +121,8 @@ namespace proc_image_processing { | |||
| ROS_ERROR("[FILTERCHAIN %s ], Error in image processing: %s", name_.c_str(), e.what()); | |||
| }; | |||
| } | |||
| // Uncomment with the timer to see filterchain performance | |||
| //ROS_INFO("Filterchain exec time: %f", timer.getExecutionTime()); | |||
There was a problem hiding this comment.
Non, ça bloat le code, mais ça pourrait être bien d'ajouter un debug pour chaque filter qu'on peut activer quand on test et que ça shoot le temps de performance
# Conflicts: # src/proc_image_processing/cpu/filters/low_pass/contrast_and_brightness_filter.h # src/proc_image_processing/cpu/filters/low_pass/equalize_filter.h # src/proc_image_processing/cpu/filters/low_pass/subtract_all_planes_filter.h # src/proc_image_processing/cpu/filters/low_pass/subtract_plane_adder_filter.h # src/proc_image_processing/cpu/filters/low_pass/thresholds/hsv_threshold_filter.h # src/proc_image_processing/cpu/filters/transformations/rotate_filter.h
Description
Fixes
How has this been tested ?
Checklist