Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang-models] sonic-mirror-session.yang miss policer leaf #9743

Closed
wen587 opened this issue Jan 12, 2022 · 2 comments
Closed

[yang-models] sonic-mirror-session.yang miss policer leaf #9743

wen587 opened this issue Jan 12, 2022 · 2 comments
Assignees
Labels
BRCM Triaged this issue has been triaged YANG YANG model related changes

Comments

@wen587
Copy link
Contributor

wen587 commented Jan 12, 2022

Description

sonic-mirror-session.yang doesn't support policer where it is needed for rate limit

Steps to reproduce the issue:

  1. Sample mirror session config contains policer.
admin@vlab-01:~/everflow$ cat session.json
{
  "MIRROR_SESSION": {
    "mirror_session_dscp": {
    "dscp": "5",
    "dst_ip": "2.2.2.2",
    "policer": "everflow_static_policer",
    "src_ip": "1.1.1.1",
    "ttl": "64",
    "type": "ERSPAN"
    }
  }
}

Describe the results you received:

Describe the results you expected:

We need to add Yang model for policer first then add the leaf for sonic-mirror-session.yang.

Output of show version:

admin@vlab-01:~/everflow$ show ver

SONiC Software Version: SONiC.master.58770-6402a0226
Distribution: Debian 11.1
Kernel: 5.10.0-8-2-amd64
Build commit: 6402a0226
Build date: Mon Dec 13 09:02:14 UTC 2021
Built by: AzDevOps@sonic-build-workers-000Z9S

Platform: x86_64-kvm_x86_64-r0
HwSKU: Force10-S6000
ASIC: vs
ASIC Count: 1
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 08:30:18 up  2:47,  2 users,  load average: 0.21, 0.35, 0.27

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@wen587
Copy link
Contributor Author

wen587 commented Jan 12, 2022

POLICER yang missing should be solved first to fix above issue.
#9742

@wen587 wen587 added the YANG YANG model related changes label Jan 12, 2022
@zhangyanzhao zhangyanzhao added Triaged this issue has been triaged BRCM labels Jan 20, 2022
@zhangyanzhao
Copy link
Collaborator

@rupesh-k can you please help to take a look? Thanks.

qiluo-msft pushed a commit that referenced this issue Feb 14, 2022
#### Why I did it
Added yang model for policer table
Fixes #9742 and #9743
#### How I did it
Creating yang model for policer

#### How to verify it
Added UT to verify the yang model

The configuration schema for policer is added in the pull request sonic-net/sonic-swss#2144
judyjoseph pushed a commit that referenced this issue Feb 22, 2022
#### Why I did it
Added yang model for policer table
Fixes #9742 and #9743
#### How I did it
Creating yang model for policer

#### How to verify it
Added UT to verify the yang model

The configuration schema for policer is added in the pull request sonic-net/sonic-swss#2144
@wen587 wen587 closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BRCM Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
Development

No branches or pull requests

2 participants