[yang]YANG model for policer table #9948
Conversation
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
dgsudharsan
added
the
Request for 202111 Branch
| @@ -0,0 +1,61 @@ | |||
| { | |||
| "POLICER_TABLE": { | |||
| "desc": "Configure policer with all fields." | |||
| description | ||
| "Committed information rate for the dual-rate token | ||
| bucket policer. This value represents the rate at which | ||
| tokens are added to the primary bucket."; |
There was a problem hiding this comment.
what's the unit? bytes per second or packets per second?
There was a problem hiding this comment.
It depends on the meter type defined. The meter type can be bytes or packets. This field by itself has no units. Please refer to https://github.com/opencomputeproject/SAI/blob/16c11ee7062e630f1eaf4bb3e44d31ab58eafa5b/inc/saipolicer.h#L123
| description | ||
| "Committed burst size for the dual-rate token bucket | ||
| policer. This value represents the depth of the token | ||
| bucket."; |
There was a problem hiding this comment.
what's the unit? bytes or packets?
There was a problem hiding this comment.
It depends on the meter type defined. The meter type can be bytes or packets. This field by itself has no units. Please refer to https://github.com/opencomputeproject/SAI/blob/16c11ee7062e630f1eaf4bb3e44d31ab58eafa5b/inc/saipolicer.h#L123
| must "((current()/../cir) and (current()/../cir > 0))" { | ||
| error-message "cbs can't be configured without cir."; | ||
| } | ||
| must "(current() >= current()/../cir)" { |
There was a problem hiding this comment.
Please refer to https://datatracker.ietf.org/doc/html/rfc4115.
The CBS and EBS are measured in bytes and must configure to be greater than the expected maximum length of the incoming PDU. The CIR and EIR are both measured in bits/s.
Maybe we need to convert unit for comparing.
There was a problem hiding this comment.
Please refer to my earlier comments regarding the units.
|
@ganglyu Please refer to copp yang table. I have reused the same definitions used there. Basically copp internally uses policer and both should be aligned in yang definitions and so I defined as in https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-copp.yang |
Can you update the descriptions for CIR, PIR, CBS and PBS to add unit? |
Done |
|
@lguohan could you please signoff? |
#### Why I did it Added yang model for policer table Fixes #9742 and #9743 #### How I did it Creating yang model for policer #### How to verify it Added UT to verify the yang model The configuration schema for policer is added in the pull request sonic-net/sonic-swss#2144
Why I did it
Added yang model for policer table
Fixes #9742 and #9743
How I did it
Creating yang model for policer
How to verify it
Added UT to verify the yang model
The configuration schema for policer is added in the pull request sonic-net/sonic-swss#2144
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)