Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phy-credo package to fix sonic-mgmt test issue and support the AOC module. #16279

Open
wants to merge 1 commit into
base: 202205
Choose a base branch
from

Conversation

abohanyang
Copy link
Contributor

Why I did it

  1. Fix an error on platforms with external phy but not using phy-credo service. Some sonic-mgmt tests fail due to this error.
  2. Add AOC support for platforms that use the phy-credo service.
Work item tracking

N/A

How I did it

  1. Gracefully return if the platform does not use the phy-credo service.
  2. Determine the medium type based on the compliance code.

How to verify it

  1. Sonic-mgmt tests no longer fail due to this phy-credo error.
  2. A port with an AOC module can come up reliably.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [x ] <202205>

Description for the changelog

N/A

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

N/A

@yxieca
Copy link
Contributor

yxieca commented Aug 26, 2023

@abohanyang is this change a cherry-pick of a master change? Why is it directly targeting 202205 branch?

@abohanyang
Copy link
Contributor Author

abohanyang commented Sep 5, 2023

Hi @yxieca

@abohanyang is this change a cherry-pick of a master change? Why is it directly targeting 202205 branch?

No. This change is not in the master branch yet. I have a separate PR for the master branch (#16280). I am not sure if I should wait for the cherry-picking or create a PR targeting 202205 directly.

@yxieca
Copy link
Contributor

yxieca commented Sep 6, 2023

@prgeor, @StormLiangMS please assess if this change should be cherry-picked to 202205. Thanks.

@@ -1,3 +1,3 @@
PHY_CREDO = phy-credo_1.0_amd64.deb
$(PHY_CREDO)_URL = "https://github.com/aristanetworks/sonic-firmware/raw/446f30ccd8626f904d89d5798da7294948e090a6/phy/phy-credo_1.0_amd64.deb"
$(PHY_CREDO)_URL = "https://github.com/aristanetworks/sonic-firmware/raw/4c6fa09910656b78103416652651b486deaba4aa/phy/phy-credo_1.0_amd64.deb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abohanyang which platform is this fix tested? Is AOC managed by Xcvrd?

Copy link
Contributor Author

@abohanyang abohanyang Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prgeor ,

This change addresses two issues:
Issue 1 "Fix an error on platforms with external phy but not using phy-credo service. Some sonic-mgmt tests fail due to this error"

  • We tested this fix against 7800R3-48CQ2-LC and 7800R3-48CQM2-LC and confirmed that phy-credo service exits gracefully on 7800R3-48CQM2-LC.

Issue 2 "Add AOC support for platforms that use the phy-credo service."

  • The phy-credo service updates the firmware settings of Credo Serdes based on the transceiver type. The AOC module is still managed by the Xcvrd.
  • 7800R3-48CQ2-LC uses phy-credo service. 7800R3-48CQM2-LC does not use phy-credo service. So we tested AOC modules on 7800R3-48CQ2-LC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants