Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phy-credo package to fix sonic-mgmt test issue and support the AOC module. #16279

Open
wants to merge 1 commit into
base: 202205
Choose a base branch
from
Open

Update phy-credo package to fix sonic-mgmt test issue and support the AOC module. #16279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/phy-credo.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
PHY_CREDO = phy-credo_1.0_amd64.deb
$(PHY_CREDO)_URL = "https://github.com/aristanetworks/sonic-firmware/raw/446f30ccd8626f904d89d5798da7294948e090a6/phy/phy-credo_1.0_amd64.deb"
$(PHY_CREDO)_URL = "https://github.com/aristanetworks/sonic-firmware/raw/4c6fa09910656b78103416652651b486deaba4aa/phy/phy-credo_1.0_amd64.deb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abohanyang which platform is this fix tested? Is AOC managed by Xcvrd?

Copy link
Contributor Author

@abohanyang abohanyang Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prgeor ,

This change addresses two issues:
Issue 1 "Fix an error on platforms with external phy but not using phy-credo service. Some sonic-mgmt tests fail due to this error"

  • We tested this fix against 7800R3-48CQ2-LC and 7800R3-48CQM2-LC and confirmed that phy-credo service exits gracefully on 7800R3-48CQM2-LC.

Issue 2 "Add AOC support for platforms that use the phy-credo service."

  • The phy-credo service updates the firmware settings of Credo Serdes based on the transceiver type. The AOC module is still managed by the Xcvrd.
  • 7800R3-48CQ2-LC uses phy-credo service. 7800R3-48CQM2-LC does not use phy-credo service. So we tested AOC modules on 7800R3-48CQ2-LC.

SONIC_ONLINE_DEBS += $(PHY_CREDO)