[Chassis] Update lossy profile to restrict buffer usage in congestion state #20132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saksarav-nokia @kenneth-arista please help review. |
|
@vmittal-msft , Is this also applicable for 202205 chassis? if so, please add the label "chassis for 202205 branch" Also update your MSFT ADO with proper branch request tags. |
vmittal-msft
changed the title
|
Hi @judyjoseph , Can you please review this? I have no experience in RDMA buffer tuning. |
vmittal-msft
added
Chassis for 202205 branch
arlakshm
reviewed
Sep 10, 2024
|
It is different to give different q limits for different port speeds. 100g port will get lesser limit then 400g. if 400g us configured as 100g, it will be set based on 100g. |
arlakshm
previously approved these changes
Sep 11, 2024
|
@vmittal-msft, do add reference to the qos tests run with these new configs, or any PR sonic-mgmt test change needed to support this. |
|
Yes. I have requested Nokia team to refer this while opening sonic-mgmt PR. |
arlakshm
reviewed
Sep 11, 2024
device/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/1/buffers_defaults_t2.j2
Outdated
Show resolved
Hide resolved
device/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/0/buffers_defaults_t2.j2
Outdated
Show resolved
Hide resolved
vmittal-msft
force-pushed
the
vmittal/lossy
branch
from
d5a61b1 to
079daa2
Compare
arlakshm
approved these changes
Sep 11, 2024
kenneth-arista
approved these changes
Sep 11, 2024
10 tasks
BYGX-wcr
added
the
Included in Chassis for 202205 Branch
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
… state (sonic-net#20132) Why I did it This change is to restrict lossy queue buffer usage in case of congestion state. Work item tracking Microsoft ADO (29315559): How I did it Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings. How to verify it It is verified using sonic-mgmt tests and running ok.
8 tasks
arlakshm
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Sep 18, 2024
…ss_pkt count for lossy profile (#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 20, 2024
… state (sonic-net#20132) Why I did it This change is to restrict lossy queue buffer usage in case of congestion state. Work item tracking Microsoft ADO (29315559): How I did it Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings. How to verify it It is verified using sonic-mgmt tests and running ok.
|
Cherry-pick PR to 202405: #20318 |
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
mssonicbld
pushed a commit
that referenced
this pull request
Sep 21, 2024
… state (#20132) Why I did it This change is to restrict lossy queue buffer usage in case of congestion state. Work item tracking Microsoft ADO (29315559): How I did it Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings. How to verify it It is verified using sonic-mgmt tests and running ok.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
ansrajpu-git
added a commit
to ansrajpu-git/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
bingwang-ms
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 8, 2024
…hresholds (#15448) * [QoS]qos_yaml j2C+ changes for new _vsq thresholds (#13069) What is the motivation for this PR? The new MMU settings to enhance performance for RDMA traffic in production. Hence the qos_params needs to be tweaked according to the set buffer profiles. However, the existing sonic-mgmt LossyQueueTest doesn't fairly verify the buffer threshold for headroom for Lossy traffic. As per the new vsq profile setting the XOFF FADT threshold/PG is way lesser than the Nominal headroom, which limits it to not utilize the headroom buffer completely and send pause frames before reaching the MAX headroom limit. Either the test case needs to be improvised by adding more source ports or a new test case should be added to verify the Lossy queue traffic at PG level * [Chassis][Voq] Updating J2C+ qos yaml for 400G and 100G profile _egress_pkt count for lossy profile (#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx * [Qos]qos_yaml updated for 400G
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
… state (sonic-net#20132) Why I did it This change is to restrict lossy queue buffer usage in case of congestion state. Work item tracking Microsoft ADO (29315559): How I did it Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings. How to verify it It is verified using sonic-mgmt tests and running ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This change is to restrict lossy queue buffer usage in case of congestion state.
Work item tracking
How I did it
Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings.
How to verify it
It is verified using sonic-mgmt tests and running ok.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)