-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating J2C+ qos yaml for 400G and 100G profile _egress_pkt count for lossy profile #14585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vmittal-msft , updated qos param change for Jr2 as well. |
vmittal-msft
approved these changes
Sep 18, 2024
kenneth-arista
approved these changes
Sep 18, 2024
@arlakshm please help approve/merge |
arlakshm
approved these changes
Sep 18, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
8 tasks
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
@ansrajpu-git PR conflicts with 202405 branch |
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
@ansrajpu-git can we please help raise a 202405 PR at priority? Thanks. |
arlakshm
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fixing intermittent failure in lossy queue by adjusting the pkts_num_trig_egr_drp for 'broadcom-dnx' t2 chassis. Updation on the original PR # #14585 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? Since the pkts_num_leakout is more for 100G.Adjusting the count of pkt sent to trigger egress drop. How did you verify/test it? Executed the qos test and verify.
ansrajpu-git
added a commit
to ansrajpu-git/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
bingwang-ms
pushed a commit
that referenced
this pull request
Nov 8, 2024
…hresholds (#15448) * [QoS]qos_yaml j2C+ changes for new _vsq thresholds (#13069) What is the motivation for this PR? The new MMU settings to enhance performance for RDMA traffic in production. Hence the qos_params needs to be tweaked according to the set buffer profiles. However, the existing sonic-mgmt LossyQueueTest doesn't fairly verify the buffer threshold for headroom for Lossy traffic. As per the new vsq profile setting the XOFF FADT threshold/PG is way lesser than the Nominal headroom, which limits it to not utilize the headroom buffer completely and send pause frames before reaching the MAX headroom limit. Either the test case needs to be improvised by adding more source ports or a new test case should be added to verify the Lossy queue traffic at PG level * [Chassis][Voq] Updating J2C+ qos yaml for 400G and 100G profile _egress_pkt count for lossy profile (#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx * [Qos]qos_yaml updated for 400G
PR ##15448 raised for 202405. |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Fixing intermittent failure in lossy queue by adjusting the pkts_num_trig_egr_drp for 'broadcom-dnx' t2 chassis. Updation on the original PR # sonic-net#14585 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? Since the pkts_num_leakout is more for 100G.Adjusting the count of pkt sent to trigger egress drop. How did you verify/test it? Executed the qos test and verify.
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Fixing intermittent failure in lossy queue by adjusting the pkts_num_trig_egr_drp for 'broadcom-dnx' t2 chassis. Updation on the original PR # sonic-net#14585 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? Since the pkts_num_leakout is more for 100G.Adjusting the count of pkt sent to trigger egress drop. How did you verify/test it? Executed the qos test and verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile.
PR #sonic-net/sonic-buildimage#20132
Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Verified the qos test case execution with the new changes.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation