[SmartSwitch] Define DPU helper functions #20724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
requested review from
prsunny,
kperumalbfn,
prgeor,
saiarcot895,
oleksandrivantsiv and
rameshraghupathy
prgeor
reviewed
Nov 9, 2024
prgeor
reviewed
Nov 9, 2024
vvolam
changed the title
prgeor
previously approved these changes
Nov 17, 2024
|
@vvolam please check the build errors |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
no unit test? |
As coverage check is not present for sonic-buildimage, lot of PRs are missing unit tests which confused me. I have added unittests for all smartswitch function in device_info.py file. Thank you for pointing this. I will work to add coverage check for sonic-buildimage PRs as well. |
prgeor
previously approved these changes
Nov 25, 2024
yxieca
previously approved these changes
Nov 25, 2024
prgeor
reviewed
Nov 25, 2024
prgeor
approved these changes
Nov 26, 2024
Pterosaur
approved these changes
Nov 26, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it Add new DPU helper functions to avoid code duplication How I did it Define new is_dpu, get_num_dpus helpers. Define get_platform_json_data and get_dpu_info helper function for common code and refactor code accordingly. How to verify it Verified the changes on smart switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add new DPU helper functions to avoid code duplication
Work item tracking
How I did it
How to verify it
Verified the changes on smart switch
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)