Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle notimplementederror exception for the plugins #99

Closed
lguohan opened this issue Aug 25, 2017 · 0 comments
Closed

handle notimplementederror exception for the plugins #99

lguohan opened this issue Aug 25, 2017 · 0 comments
Assignees

Comments

@lguohan
Copy link
Contributor

lguohan commented Aug 25, 2017

in sfputil, gracefully catch notimplementederror exception throw by plugins and print out error instead of throw traceback stack.

admin@str-msn2700-20:/usr/share/sonic/device/x86_64-mlnx_msn2700-r0/plugins$ sudo sfputil show lpmode
Traceback (most recent call last):
  File "/usr/bin/sfputil", line 9, in <module>
    load_entry_point('sonic-utilities==1.1', 'console_scripts', 'sfputil')()
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/sfputil/main.py", line 514, in lpmode
    lpmode = platform_sfputil.get_low_power_mode(physical_port)
  File "/usr/share/sonic/device/x86_64-mlnx_msn2700-r0/plugins/sfputil.py", line 54, in get_low_power_mode
    raise NotImplementedError
NotImplementedError
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this issue Apr 28, 2022
[sfp_base] Update return value documentation of channel-specific methods
(sonic-net#98)
[SfpBase] Fix key name typo in docstring (sonic-net#99)
[sfp] Tweak key names of some transceiver info fields (sonic-net#97)
[sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as
in SfpUtilBase (sonic-net#96)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this issue Apr 28, 2022
a1830c1761087bdc1f7433ebbb8d0bdc419da0d3 (HEAD -> 201911, origin/master, origin/HEAD, origin/201911) Fix OpenAPI spec to be readable by autorest (sonic-net#101)
94805a39ac0712219f7dc08faa2cfdbf371dd177 Identify and report Vnet GUID for conflicting VNI (sonic-net#99)
4832dfd677de72edc44d4eb8c1b60cfad79a3355 Static route expiry if not specified as persistent  (sonic-net#98)
5cc4358fb67b9e2a0da9a6691064e41f97ebebc2 (master) Add support for overlay ECMP (sonic-net#96)
6822a46197daef060b4d00dba5153b04b163c43f [CI] Set diff cover threshold to 50% (sonic-net#97)
dcc826a1503060b9a07e4510b4f48331c49e87dd Add PR diff coverage (sonic-net#95)
e842c5ff317c67919dcbcab3358143cb9a16c9dd Generate code coverage for Unit Tests (sonic-net#94)
f9bbed3cb86a3bab9a07745096835dbdbe5a4db6 Convert Unit Tests from unittest framework to pytest framework (sonic-net#93)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this issue Sep 15, 2023
Fix key name typo: "mominal_bit_rate" -> "nominal_bit_rate"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants