[FastReboot]: Update FR to make it working with 1.0.3 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment why it was closed? |
lguohan
reviewed
Aug 14, 2017
| @@ -49,24 +53,56 @@ def get_vlan_ifaces(): | |||
|
|
|||
| return vlans | |||
|
|
|||
| def get_bridge_port_id_2_port_id(db): | |||
| bridge_port_id_2_port_id = {} | |||
| keys = db.keys(db.ASIC_DB, 'ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:*') | |||
There was a problem hiding this comment.
how to make sure the ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT table is available be the time you run this function?
There was a problem hiding this comment.
is it possible the asic db is not completely initialized and you do not have all bridge_port id to port id mappings?
There was a problem hiding this comment.
I run this command before the switch goes into the FR. I think external tools should check a state of a switch before the initiate FR.
There was a problem hiding this comment.
It's possible, but if the device is not initialized we shouldn't reboot a device.
lguohan
approved these changes
Aug 14, 2017
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
* msft_github/master: Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113) CLI support for Layer 2 MAC/FDB show (sonic-net#106) [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107) Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102) [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104) Added syncd SAI dump to sysdump script (sonic-net#89) Adapt to new minigraph_parser schema (sonic-net#103) [core dump] remove number of parameter assumption from script coredump-compress [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
Add 'wheel' to the list of packages required for building the package. This way it will be implicitly installed at build time, preventing the need to install the 'wheel' package explicitly in our build environment.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
a1830c1761087bdc1f7433ebbb8d0bdc419da0d3 (HEAD -> 201911, origin/master, origin/HEAD, origin/201911) Fix OpenAPI spec to be readable by autorest (sonic-net#101) 94805a39ac0712219f7dc08faa2cfdbf371dd177 Identify and report Vnet GUID for conflicting VNI (sonic-net#99) 4832dfd677de72edc44d4eb8c1b60cfad79a3355 Static route expiry if not specified as persistent (sonic-net#98) 5cc4358fb67b9e2a0da9a6691064e41f97ebebc2 (master) Add support for overlay ECMP (sonic-net#96) 6822a46197daef060b4d00dba5153b04b163c43f [CI] Set diff cover threshold to 50% (sonic-net#97) dcc826a1503060b9a07e4510b4f48331c49e87dd Add PR diff coverage (sonic-net#95) e842c5ff317c67919dcbcab3358143cb9a16c9dd Generate code coverage for Unit Tests (sonic-net#94) f9bbed3cb86a3bab9a07745096835dbdbe5a4db6 Convert Unit Tests from unittest framework to pytest framework (sonic-net#93) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…et#95) * Check the status using the sysfs pci enumeration point instead of lspci * indentation * review comments * change the file name in the description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.