Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[show]: Add 'show interfaces alias' command to display port name/alias mapping #107

Merged
merged 1 commit into from
Sep 27, 2017
Merged

[show]: Add 'show interfaces alias' command to display port name/alias mapping #107

merged 1 commit into from
Sep 27, 2017

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Sep 26, 2017 •
edited
Loading

Sample output:

admin@sonic:~$ show interfaces alias
Name         Alias
-----------  --------------
Ethernet0    fortyGigE0/0
Ethernet4    fortyGigE0/4
Ethernet8    fortyGigE0/8
Ethernet12   fortyGigE0/12
Ethernet16   fortyGigE0/16
Ethernet20   fortyGigE0/20
Ethernet24   fortyGigE0/24
Ethernet28   fortyGigE0/28
Ethernet32   fortyGigE0/32
Ethernet36   fortyGigE0/36
Ethernet40   fortyGigE0/40
Ethernet44   fortyGigE0/44
Ethernet48   fortyGigE0/48
Ethernet52   fortyGigE0/52
Ethernet56   fortyGigE0/56
Ethernet60   fortyGigE0/60
Ethernet64   fortyGigE0/64
Ethernet68   fortyGigE0/68
Ethernet72   fortyGigE0/72
Ethernet76   fortyGigE0/76
Ethernet80   fortyGigE0/80
Ethernet84   fortyGigE0/84
Ethernet88   fortyGigE0/88
Ethernet92   fortyGigE0/92
Ethernet96   fortyGigE0/96
Ethernet100  fortyGigE0/100
Ethernet104  fortyGigE0/104
Ethernet108  fortyGigE0/108
Ethernet112  fortyGigE0/112
Ethernet116  fortyGigE0/116
Ethernet120  fortyGigE0/120
Ethernet124  fortyGigE0/124

admin@sonic:~$ show interfaces alias Ethernet44
Name        Alias
----------  -------------
Ethernet44  fortyGigE0/44

@jleveque jleveque self-assigned this Sep 26, 2017
nikos-github
nikos-github suggested changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@nikos-github nikos-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add appropriate output from your testing and to show how the cmd output looks like.

@jleveque
Copy link
Contributor Author

@Nikos-Li: Sample output added to PR description.

@lguohan lguohan merged commit 70422b5 into sonic-net:master Sep 27, 2017
@jleveque jleveque deleted the show_alias branch September 27, 2017 16:31
@nikos-github
Copy link
Contributor

show interface portmap does the same thing. Why do we need yet another command?

@jleveque
Copy link
Contributor Author

@Nikos-Li: SONiC does not have a show interface portmap command. What are you referring to?

@nikos-github
Copy link
Contributor

@jleveque It is up for review, isn't it? #98

@jleveque
Copy link
Contributor Author

@Nikos-Li: That PR is held up due to the debate over the Clear command. Also, this solution is cleaner as it doesn't require the writing of template files. If you prefer the command name portmap over alias, please open a new issue and we can discuss it there.

@nikos-github
Copy link
Contributor

@jleveque You could have suggested those changes in show interface portmap if you thought it was a better solution. Merging code that hasn't been cleared from all reviewers, is not acceptable. Especially when a solution for the same issue is in review.

zhenggen-xu pushed a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
Merge remote-tracking branch 'msft_github/master'
99cb169 
* msft_github/master:
  Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113)
  CLI support for Layer 2 MAC/FDB show  (sonic-net#106)
  [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107)
  Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102)
  [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104)
  Added syncd SAI dump to sysdump script (sonic-net#89)
  Adapt to new minigraph_parser schema (sonic-net#103)
  [core dump] remove number of parameter assumption from script coredump-compress
  [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@jleveque
[xcvrd] Add enum dependence back; Install 'enum34' conditionally base…
600d043 
…d on Python version (sonic-net#107)

Add dependence on 'enum' package back to xcvrd (basically reverting most of sonic-net/sonic-platform-daemons#106). However, in setup.py, we only install the enum34 package if the version of Python we are installing for is < 3.4. Thus, when installing the Python 3 xcvrd package in Python 2.7, the Python 2 version of enum34 will be installed. However, if installing the Python 3 xcvrd package on Python 3.7, enum34 will not be installed, causing xcrvd to import the 'enum' module from the standard library. This should prevent any conflicts which arise when 'enum34' is ever installed on Python versions >= 3.4 by preventing this situation.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@SuvarnaMeenakshi
[sonic-py-swsssdk]: Advance submodule (#10118)
a8f1e6e 
9688ef4 Add missing functions to be on par with swsscommon. (sonic-net#107)

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikos-github nikos-github nikos-github requested changes

@kcudnik kcudnik kcudnik approved these changes

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jleveque @nikos-github @lguohan @kcudnik @msftclas @msftgits