Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added syncd SAI dump to sysdump script #89

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

andrii-savka
Copy link

It should merged only after following request:
sonic-net/sonic-sairedis#199

@msftclas
Copy link

@andrii-savka,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@@ -285,6 +285,11 @@ main() {
save_redis "2" "COUNTERS_DB"

save_cmd "docker exec -it syncd saidump" "saidump"

local sai_dump_filename="/tmp/syncd_sai_dump"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add timestamp?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be only on mellanox platform since it is the only platform that supports this.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it only run on mellanox platform.

@andrii-savka
Copy link
Author

Fixed above remarks.
Thanks.

@andrii-savka
Copy link
Author

The saisdkdump tool is already merged.
All remarks are fixed.
So we can merge this request.

@lguohan
Copy link
Contributor

lguohan commented Aug 9, 2017

cannot merge this one, since the change is checked into 1.0.3 branch. It can only be merged after 1.0.3 branch is merged into master.

@lguohan lguohan merged commit 85dd072 into sonic-net:master Sep 19, 2017
zhenggen-xu pushed a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
* msft_github/master:
  Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (sonic-net#113)
  CLI support for Layer 2 MAC/FDB show  (sonic-net#106)
  [show]: Add 'show interfaces alias' command to display port name/alias mapping (sonic-net#107)
  Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove duplicate commands ('bgp,' 'route') from under root group (sonic-net#102)
  [generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104)
  Added syncd SAI dump to sysdump script (sonic-net#89)
  Adapt to new minigraph_parser schema (sonic-net#103)
  [core dump] remove number of parameter assumption from script coredump-compress
  [FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
stepanblyschak referenced this pull request in stepanblyschak/sonic-utilities Apr 28, 2022
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (#91)
07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (#89)
47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (#90)
ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (#87)
6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (#85)
d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (#68)
8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (#78)
fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (#82)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants