[config load_mgmt_config] add default route #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Oct 6, 2017
| command = "ifconfig eth0 {} netmask {}".format(str(mgmt_conf.ip), str(mgmt_conf.netmask)) | ||
| run_command(command, display_cmd=True) | ||
| command = "ip route add default via {} dev eth0 table default".format(gw_addr) |
There was a problem hiding this comment.
is this management address ipv4? In our template, we support ipv6 mgmt port.
There was a problem hiding this comment.
Current device_desc file parser enforces that mgmt address is ipv4.
lguohan
approved these changes
Oct 6, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
Implement a better check for logical_port_name_to_physical_port_list function. Currently it will only accept names that start with "Ethernet". If we try to add other ports it will crash. In the future Arista will implement other port types. For example "Recirc0". Co-authored-by: Zhi Yuan Carl Zhao <zyzhao@arista.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
…(#4193) * [Mellanox]Integrate hw-mgmt 7.0000.3012 * [sonic-linux-kernel]Advance the submodule head Advance the sonic-linux-kernel [sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120) Added support in the kernel for fullcone 3-tuple unique nat. (sonic-net#100) Adding support to compile ARM architecture (sonic-net#102) [ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122) Fix i2c ISMT DMA buffer alignment issue (sonic-net#123) [mellanox]: Add SN4700 patches. (sonic-net#126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default route through mgmt when load device description files.