Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] Avoid error in config load_mgmt_conf when mgmt is already co… #126

Merged
merged 3 commits into from
Oct 6, 2017
Merged

[config] Avoid error in config load_mgmt_conf when mgmt is already co… #126

merged 3 commits into from
Oct 6, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Oct 6, 2017

…nfigured

@taoyl-ms taoyl-ms requested a review from lguohan October 6, 2017 21:16
jleveque
jleveque suggested changes Oct 6, 2017
View reviewed changes
config/main.py Outdated
command = "[ -f /var/run/dhclient.eth0.pid ] && kill `cat /var/run/dhclient.eth0.pid` && rm -f /var/run/dhclient.eth0.pid"
run_command(command, display_cmd=True)
run_command(command, display_cmd=True. ignore_error=True)
Copy link
Contributor

@jleveque jleveque Oct 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo, period instead of comma after first "True": display_cmd=True.

@taoyl-ms taoyl-ms merged commit aa3254b into sonic-net:master Oct 6, 2017
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@lguohan @abdosi
[Mellanox]Integrate hw-mgmt 7.0000.3012 and advance the linux kernel …
9eb3a1b 
…(#4193)

* [Mellanox]Integrate hw-mgmt 7.0000.3012

* [sonic-linux-kernel]Advance the submodule head

Advance the sonic-linux-kernel

[sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120)
Added support in the kernel for fullcone 3-tuple unique nat. (sonic-net#100)
Adding support to compile ARM architecture (sonic-net#102)
[ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122)
Fix i2c ISMT DMA buffer alignment issue (sonic-net#123)
[mellanox]: Add SN4700 patches. (sonic-net#126)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[Submodule update] sonic-snmpagent. Movent to 201911 Branch with with
b78e17a 
following PR's :
Implement cbgpPeer2State in CiscoBgp4MIB (sonic-net#119)
Fix index nodes in LLDP tables whose access right is not-accessible.
(sonic-net#112)
 Fix quagga/FRR parser on IPv6 BGP sessions (sonic-net#122)
 [lint] Fix some syntax errors or warnings (sonic-net#127)
  Update README.md: Add lgtm badges (sonic-net#128)
  [Multi-asic]: Support multi-asic platform (sonic-net#126)
  Simplify test code (sonic-net#132)
  [Multi-asic]: Namespace support for LLDP and Sensor tables (sonic-net#131)
  Fix undefined variable and warning message (sonic-net#134)
  Fix SNMP AgentX socket connection timeout when using
  Namespace.get_all() (sonic-net#140)
  [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (sonic-net#141)
   Fix LGTM reported alert of PR#141 (sonic-net#142)
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
@vdahiya12
[SONIC_SFP] adding abstract methods for reading and writing the eepro…
a659219 
…m address space within platform api (sonic-net#126)

* [sonic_sfp] adding abstract methods for platform api's

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taoyl-ms @lguohan @jleveque