-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show commands for SYSTEM READY #1851
Conversation
This pull request introduces 1 alert when merging a488880a0b9ed6c8e2b9210b6697519b34a600e0 into 5bdf270 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 68a3d1fc5a76be11e1189619226cc89e8caf9804 into 5bdf270 - view on LGTM.com new alerts:
|
68a3d1f
to
201203d
Compare
This pull request introduces 1 alert when merging 201203d4fe7e6962e6cb5e273dff754a14795e27 into f53baac - view on LGTM.com new alerts:
|
retest this please |
Can we please capture all show commands output as well? |
201203d
to
5b9ff62
Compare
This pull request introduces 1 alert when merging 5b9ff62 into efbe1f4 - view on LGTM.com new alerts:
|
Have updated "New command output" section with all the show commands output and also attached the UT log file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangyanzhao please don't merge this PR.
the HLD is now reverted and the other referenced PR should also be reverted until we agree on the HLD approach.
This pull request introduces 5 alerts when merging 434fcf2 into 9e2fbf4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 288b748 into d012be9 - view on LGTM.com new alerts:
|
f609301
to
7e0529d
Compare
This pull request introduces 1 alert when merging 7e0529d into fdb79b8 - view on LGTM.com new alerts:
|
9a8efea
to
48a468d
Compare
This pull request introduces 1 alert when merging 48a468d into fdb79b8 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bdbfe85 into fdb79b8 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Senthil Kumar Guruswamy, could you please merge this PR?
This pull request introduces 1 alert when merging 86e3aea into d7953d2 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 350cf66 into 4fc09b1 - view on LGTM.com new alerts:
|
Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <drorp@nvidia.com>
@sg893052 this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR. |
|
If you checkout 202205 branch and cherry-pick this change in, you will see the conflict. |
What I did show command support for System Ready Feature Implementation . Also sonic-package-manager support for app readiness. "show system-health sysready-status" "show system-health sysready-status detail" "show system-health sysready-status brief" How I did it Introduce "show system-health sysready-status" click CLI with options. How to verify it Check the click CLIs introduced.
What I did show command support for System Ready Feature Implementation . Also sonic-package-manager support for app readiness. "show system-health sysready-status" "show system-health sysready-status detail" "show system-health sysready-status brief" How I did it Introduce "show system-health sysready-status" click CLI with options. How to verify it Check the click CLIs introduced.
@sg893052 When do you expect to merge it? |
What I did
show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.
"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"
How I did it
Introduce "show system-health sysready-status" click CLI with options.
How to verify it
Check the click CLIs introduced.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)