Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show commands for SYSTEM READY (#1851) #2261

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

sg893052
Copy link
Contributor

@sg893052 sg893052 commented Jul 8, 2022

What I did
show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it
Introduce "show system-health sysready-status" click CLI with options.

How to verify it
Check the click CLIs introduced.

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

What I did
show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it
Introduce "show system-health sysready-status" click CLI with options.

How to verify it
Check the click CLIs introduced.
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2022

This pull request introduces 1 alert when merging 4a0d969 into 9f496a0 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yxieca yxieca merged commit a6404b7 into sonic-net:202205 Jul 17, 2022
@yxieca
Copy link
Contributor

yxieca commented Jul 18, 2022

@sg893052 this change caused build failure when advances the submodule head. Can you address the issue?

@sg893052
Copy link
Contributor Author

sg893052 commented Jul 19, 2022

@sg893052 this change caused build failure when advances the submodule head. Can you address the issue?

Could you please share the link for build failure log?

From Jobs in run #20220719.5 (https://dev.azure.com/mssonic/build/_build/results?buildId=124124&view=results),
I could see sonic-utilites is still with 9f496a0.

Could you please clarify if you did try advancing the sonic-utilities to a6404b7 in your local view and saw the build failure? If so, please share the build log.

@yxieca
Copy link
Contributor

yxieca commented Jul 22, 2022

@sg893052 Please cherry-pick this change to your local repo and build

yxieca added a commit that referenced this pull request Jul 22, 2022
yxieca added a commit that referenced this pull request Jul 22, 2022
@yxieca
Copy link
Contributor

yxieca commented Oct 27, 2022

@sg893052 this change caused build failure when advances the submodule head. Can you address the issue?

Could you please share the link for build failure log?

From Jobs in run #20220719.5 (https://dev.azure.com/mssonic/build/_build/results?buildId=124124&view=results), I could see sonic-utilites is still with 9f496a0.

Could you please clarify if you did try advancing the sonic-utilities to a6404b7 in your local view and saw the build failure? If so, please share the build log.

yes. this commit causes build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants