Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store real IRC server name #1532

Closed
deathbybandaid opened this issue Apr 1, 2019 · 5 comments · Fixed by #1769
Closed

Store real IRC server name #1532

deathbybandaid opened this issue Apr 1, 2019 · 5 comments · Fixed by #1769
Labels
Core/IRC Protocol Handling Feature Low Priority

Comments

@deathbybandaid
Copy link
Contributor

I think it is prudent to have a concise location of all things server related.

Servername would be nice to have. If a bot is connected to a bouncer like ZNC, reading the value in the config file isn't super helpful.
@dgw dgw changed the title Servername Store real IRC server name Apr 1, 2019
@dgw
Copy link
Member

dgw commented Apr 1, 2019

Is it more useful to have the server's hostname (like asimov.freenode.net) or the network name (meaning freenode)?

Both? It couldn't hurt to store both, I guess.

@deathbybandaid
Copy link
Contributor Author

both would be super handy

@dgw
Copy link
Member

dgw commented Apr 1, 2019 •
edited
Loading

OK, both. That didn't take much convincing.

You proposed bot.server to hold this stuff on IRC. Running with that, bot.server.network (from RPL_ISUPPORT / numeric 005, ref: #1082) and bot.server.hostname?

@deathbybandaid
Copy link
Contributor Author

I like it,,, might also be a cleaner place to store bot.server.capabilities than bot.server_capabilites

@dgw
Copy link
Member

dgw commented Apr 1, 2019

Could also make sense to use bot.network, but we can bikeshed the names later lol.

HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters of interest from RPL_ISUPPORT
1d685ae 
Selectively exposes parameters from sopel-irc#1082. Attempts to access parameters
outside of those (whether actually present or not), will issue a
`RuntimeWarning`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters of interest from RPL_ISUPPORT
648a551 
Selectively exposes parameters from sopel-irc#1082. Attempts to access parameters
outside of those (whether actually present or not), will issue a
`RuntimeWarning`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters of interest from RPL_ISUPPORT
b7eeeec 
Selectively exposes parameters from sopel-irc#1082. Attempts to access parameters
outside of those (whether actually present or not), will issue a
`RuntimeWarning`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters from RPL_ISUPPORT at the top of bot.server
2ec80db 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters from RPL_ISUPPORT at the top of bot.server
e7319b3 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
@HumorBaby HumorBaby mentioned this issue Apr 2, 2019
Closed
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters from RPL_ISUPPORT at the top of bot.server
9d900b9 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters from RPL_ISUPPORT at the top of bot.server
9b2dfc1 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 2, 2019
@HumorBaby
feat: expose parameters from RPL_ISUPPORT at the top of bot.server
40b0334 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 18, 2019
@HumorBaby
core: expose parameters from RPL_ISUPPORT at the top of bot.server
382d337 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 18, 2019
@HumorBaby
core: expose parameters from RPL_ISUPPORT at the top of bot.server
011df5b 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
HumorBaby added a commit to HumorBaby/sopel that referenced this issue Apr 23, 2019
@HumorBaby
core: expose parameters from RPL_ISUPPORT at the top of bot.server
3bcce32 
`ISUPPORT` parameters can be accessed as `bot.server...`, e.g.,
`bot.server.NAMESX`.

This closes sopel-irc#1082 and closes sopel-irc#1532.
@Exirel Exirel mentioned this issue Nov 28, 2019
Merged
@dgw dgw closed this as completed in #1769 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core/IRC Protocol Handling Feature Low Priority
Projects
None yet
Milestone
No milestone
3 participants
@dgw @Exirel @deathbybandaid