Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: handle 004 RPL_MYINFO event #1769

Merged
merged 5 commits into from
Dec 12, 2019
Merged

core: handle 004 RPL_MYINFO event #1769

merged 5 commits into from
Dec 12, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Nov 28, 2019

This closes #1532 by handling the RPL_MYINFO event and storing the info into a namedtuple. This PR replaces a part of #1536. (see also #1758)

@Exirel Exirel added this to the 7.0.0 milestone Nov 28, 2019
@Exirel Exirel requested a review from a team November 28, 2019 13:56
@dgw dgw self-requested a review November 30, 2019 07:19
dgw
dgw requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Itty bitty change-request committee. 🙌

sopel/irc/__init__.py Outdated Show resolved Hide resolved
sopel/irc/utils.py Outdated Show resolved Hide resolved
sopel/irc/utils.py Show resolved Hide resolved
sopel/coretasks.py Outdated Show resolved Hide resolved
test/test_coretasks.py Outdated Show resolved Hide resolved
@dgw dgw removed the request for review from a team December 6, 2019 00:31
@Exirel Exirel requested a review from dgw December 9, 2019 09:31
dgw
dgw approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd already approved this… Sorry for the delay. Must have gotten called away from my previous approval before clicking the button, or something.

@Exirel
Copy link
Contributor Author

Exirel commented Dec 11, 2019

Rebased, conflict resolved, and squashed. But I'll have new conflict once #1758 is merged, I know it.

@dgw
Copy link
Member

dgw commented Dec 11, 2019

#1758 might conflict, or it might not. But meanwhile, ninja #1751 appeared and caused conflicts for BOTH of these other PRs. "No one expects the JOIN/WHO Inquisition!"

Exirel and others added 4 commits December 12, 2019 11:13
@Exirel
irc: ISupport class and basic parsing
2a44ae9
@Exirel @dgw
core: handle RPL_ISUPPORT
4c82c75 
You can access ISUPPORT information from:

* bot.isupport['KEY'] (where KEY is case-insensitive)
* bot.KEY when advertised by the server (where KEY is case-sensitive)

Co-Authored-By: dgw <dgw@technobabbl.es>
@Exirel
isupport: rename ISUPPORT_PARSER to ISUPPORT_PARSERS
bc4a104
@Exirel
isupport: rename kwargs_ci to kwargs_upper
4758184
@Exirel Exirel mentioned this pull request Dec 12, 2019
Merged
@Exirel @dgw
core: handle 004 RPL_MYINFO event
52455a9 
Co-Authored-By: dgw <dgw@technobabbl.es>
@Exirel
Copy link
Contributor Author

Exirel commented Dec 12, 2019

@dgw conflicts resolved, and I rebased upon #1758 so you can merge them back to back.

@dgw dgw merged commit 185686f into sopel-irc:master Dec 12, 2019
@maxpowa maxpowa mentioned this pull request Dec 12, 2019
Closed
7 tasks
@Exirel Exirel deleted the irc-myinfo branch January 14, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Feature Low Priority
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Store real IRC server name
2 participants
@Exirel @dgw