core: handle 005 RPL_ISUPPORT event #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting closer to the end: now the ISupport class is able to build a new instance of ISupport by applying changes! What's left: adding the right rule callables. |
Exirel
changed the title
dgw
requested changes
Dec 6, 2019
There was a problem hiding this comment.
Finally got to this. It's exciting! It was ready not long before my trip out of town for Thanksgiving, and I unfortunately didn't really have a chance to look at it until now (after getting back home). But boy, was it worth the wait!
There are just a few actual questions; most of the line comments are just typos/wording suggestions.
|
Rebased, conflict resolved, and squashed. |
|
#1751 why? You betrayed me. |
dgw
reviewed
Dec 12, 2019
You can access ISUPPORT information from: * bot.isupport['KEY'] (where KEY is case-insensitive) * bot.KEY when advertised by the server (where KEY is case-sensitive) Co-Authored-By: dgw <dgw@technobabbl.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to show a bit of the ISupport thing: my idea is to have a storage structure with the basic parsing tools at first. Then, I'll implement an actual callable, triggered by the event
RPL_ISUPPORT, with the proper machinery to parse, update, and remove ISupport data.This Draft version aims to open a small conversation about the design and the usability of the ISupport class.
Quick note: the ISupport class will generate immutable object. There is no good reason to mess with that, as every bit of information comes from the server itself.